From 6a01fc4ab7594d5c77de5c6021eae8ef767d3b7e Mon Sep 17 00:00:00 2001
From: clemahieu <clemahieu@gmail.com>
Date: Mon, 25 Sep 2023 19:16:30 +0100
Subject: [PATCH] Removing incorrect forward declarations of transaction
 classes (#4294)

This was changed with the extraction of the store class.
---
 nano/lib/rep_weights.hpp                    | 1 -
 nano/node/active_transactions.hpp           | 1 -
 nano/node/blockprocessor.hpp                | 3 ---
 nano/node/bootstrap_ascending/service.hpp   | 1 -
 nano/node/confirmation_height_bounded.hpp   | 1 -
 nano/node/confirmation_height_unbounded.hpp | 1 -
 nano/node/gap_cache.hpp                     | 1 -
 nano/node/online_reps.hpp                   | 1 -
 nano/node/vote_processor.hpp                | 1 -
 nano/store/account.hpp                      | 3 ---
 nano/store/block.hpp                        | 3 ---
 nano/store/confirmation_height.hpp          | 3 ---
 nano/store/final.hpp                        | 3 ---
 nano/store/frontier.hpp                     | 3 ---
 nano/store/lmdb/lmdb.hpp                    | 1 -
 nano/store/online_weight.hpp                | 3 ---
 nano/store/peer.hpp                         | 3 ---
 nano/store/pending.hpp                      | 3 ---
 nano/store/pruned.hpp                       | 3 ---
 nano/store/version.hpp                      | 3 ---
 20 files changed, 42 deletions(-)

diff --git a/nano/lib/rep_weights.hpp b/nano/lib/rep_weights.hpp
index 6073bdc762..e7716ee3b2 100644
--- a/nano/lib/rep_weights.hpp
+++ b/nano/lib/rep_weights.hpp
@@ -13,7 +13,6 @@ namespace store
 {
 	class component;
 }
-class transaction;
 
 class rep_weights
 {
diff --git a/nano/node/active_transactions.hpp b/nano/node/active_transactions.hpp
index 2b598e2b00..bf54078db6 100644
--- a/nano/node/active_transactions.hpp
+++ b/nano/node/active_transactions.hpp
@@ -28,7 +28,6 @@ class block;
 class block_sideband;
 class election;
 class vote;
-class transaction;
 class confirmation_height_processor;
 class stats;
 
diff --git a/nano/node/blockprocessor.hpp b/nano/node/blockprocessor.hpp
index 5c2c6b9cbf..465bc5f6fd 100644
--- a/nano/node/blockprocessor.hpp
+++ b/nano/node/blockprocessor.hpp
@@ -18,9 +18,6 @@ class write_transaction;
 namespace nano
 {
 class node;
-class read_transaction;
-class transaction;
-class write_transaction;
 class write_database_queue;
 
 /**
diff --git a/nano/node/bootstrap_ascending/service.hpp b/nano/node/bootstrap_ascending/service.hpp
index 0a83f3c9cf..a518b3b3da 100644
--- a/nano/node/bootstrap_ascending/service.hpp
+++ b/nano/node/bootstrap_ascending/service.hpp
@@ -27,7 +27,6 @@ class block_processor;
 class ledger;
 class network;
 class node_config;
-class transaction;
 
 namespace transport
 {
diff --git a/nano/node/confirmation_height_bounded.hpp b/nano/node/confirmation_height_bounded.hpp
index accf2aa34c..c176b41686 100644
--- a/nano/node/confirmation_height_bounded.hpp
+++ b/nano/node/confirmation_height_bounded.hpp
@@ -11,7 +11,6 @@
 namespace nano
 {
 class ledger;
-class read_transaction;
 class logging;
 class logger_mt;
 class write_database_queue;
diff --git a/nano/node/confirmation_height_unbounded.hpp b/nano/node/confirmation_height_unbounded.hpp
index 61dbc75598..0af353e69a 100644
--- a/nano/node/confirmation_height_unbounded.hpp
+++ b/nano/node/confirmation_height_unbounded.hpp
@@ -12,7 +12,6 @@
 namespace nano
 {
 class ledger;
-class read_transaction;
 class logging;
 class logger_mt;
 class write_database_queue;
diff --git a/nano/node/gap_cache.hpp b/nano/node/gap_cache.hpp
index cd26dd2823..118625fd35 100644
--- a/nano/node/gap_cache.hpp
+++ b/nano/node/gap_cache.hpp
@@ -16,7 +16,6 @@
 namespace nano
 {
 class node;
-class transaction;
 
 /** For each gap in account chains, track arrival time and voters */
 class gap_information final
diff --git a/nano/node/online_reps.hpp b/nano/node/online_reps.hpp
index ea9e6aea11..98fd8c519e 100644
--- a/nano/node/online_reps.hpp
+++ b/nano/node/online_reps.hpp
@@ -16,7 +16,6 @@ namespace nano
 {
 class ledger;
 class node_config;
-class transaction;
 
 /** Track online representatives and trend online weight */
 class online_reps final
diff --git a/nano/node/vote_processor.hpp b/nano/node/vote_processor.hpp
index ee8452abb4..0ffb39dd00 100644
--- a/nano/node/vote_processor.hpp
+++ b/nano/node/vote_processor.hpp
@@ -28,7 +28,6 @@ class network_params;
 class node_flags;
 class stats;
 
-class transaction;
 namespace transport
 {
 	class channel;
diff --git a/nano/store/account.hpp b/nano/store/account.hpp
index 1b6a35aa3c..9d20fdd384 100644
--- a/nano/store/account.hpp
+++ b/nano/store/account.hpp
@@ -9,9 +9,6 @@
 namespace nano
 {
 class block_hash;
-class read_transaction;
-class transaction;
-class write_transaction;
 }
 namespace nano::store
 {
diff --git a/nano/store/block.hpp b/nano/store/block.hpp
index 459720886f..826aafc41c 100644
--- a/nano/store/block.hpp
+++ b/nano/store/block.hpp
@@ -10,9 +10,6 @@
 namespace nano
 {
 class block_hash;
-class read_transaction;
-class transaction;
-class write_transaction;
 }
 namespace nano::store
 {
diff --git a/nano/store/confirmation_height.hpp b/nano/store/confirmation_height.hpp
index 07588c491e..f0cb5ee73c 100644
--- a/nano/store/confirmation_height.hpp
+++ b/nano/store/confirmation_height.hpp
@@ -9,9 +9,6 @@
 namespace nano
 {
 class block_hash;
-class read_transaction;
-class transaction;
-class write_transaction;
 }
 namespace nano::store
 {
diff --git a/nano/store/final.hpp b/nano/store/final.hpp
index da7bc990c6..1b9f159951 100644
--- a/nano/store/final.hpp
+++ b/nano/store/final.hpp
@@ -9,9 +9,6 @@
 namespace nano
 {
 class block_hash;
-class read_transaction;
-class transaction;
-class write_transaction;
 }
 namespace nano::store
 {
diff --git a/nano/store/frontier.hpp b/nano/store/frontier.hpp
index 0405cf9fbe..b4d504d416 100644
--- a/nano/store/frontier.hpp
+++ b/nano/store/frontier.hpp
@@ -9,9 +9,6 @@
 namespace nano
 {
 class block_hash;
-class read_transaction;
-class transaction;
-class write_transaction;
 }
 namespace nano::store
 {
diff --git a/nano/store/lmdb/lmdb.hpp b/nano/store/lmdb/lmdb.hpp
index 6e935ed5fc..cd741d5c9e 100644
--- a/nano/store/lmdb/lmdb.hpp
+++ b/nano/store/lmdb/lmdb.hpp
@@ -37,7 +37,6 @@ namespace filesystem
 namespace nano
 {
 class logging_mt;
-class transaction;
 
 }
 
diff --git a/nano/store/online_weight.hpp b/nano/store/online_weight.hpp
index 260e085297..aa17938e86 100644
--- a/nano/store/online_weight.hpp
+++ b/nano/store/online_weight.hpp
@@ -9,9 +9,6 @@
 namespace nano
 {
 class block_hash;
-class read_transaction;
-class transaction;
-class write_transaction;
 }
 namespace nano::store
 {
diff --git a/nano/store/peer.hpp b/nano/store/peer.hpp
index 149b4b3b18..5f2aeb9766 100644
--- a/nano/store/peer.hpp
+++ b/nano/store/peer.hpp
@@ -9,9 +9,6 @@
 namespace nano
 {
 class block_hash;
-class read_transaction;
-class transaction;
-class write_transaction;
 }
 namespace nano::store
 {
diff --git a/nano/store/pending.hpp b/nano/store/pending.hpp
index 7c11283494..6c5b379323 100644
--- a/nano/store/pending.hpp
+++ b/nano/store/pending.hpp
@@ -9,9 +9,6 @@
 namespace nano
 {
 class block_hash;
-class read_transaction;
-class transaction;
-class write_transaction;
 }
 namespace nano::store
 {
diff --git a/nano/store/pruned.hpp b/nano/store/pruned.hpp
index cab488577f..cc40c812b8 100644
--- a/nano/store/pruned.hpp
+++ b/nano/store/pruned.hpp
@@ -9,9 +9,6 @@
 namespace nano
 {
 class block_hash;
-class read_transaction;
-class transaction;
-class write_transaction;
 }
 namespace nano::store
 {
diff --git a/nano/store/version.hpp b/nano/store/version.hpp
index 46089dcc8f..79b294e3b0 100644
--- a/nano/store/version.hpp
+++ b/nano/store/version.hpp
@@ -8,9 +8,6 @@
 namespace nano
 {
 class block_hash;
-class read_transaction;
-class transaction;
-class write_transaction;
 }
 namespace nano::store
 {