Production builds should not include LinkConditionerConfig

[connorcarpenter]

Conditionally compile LinkConditionerConfig so that no conditioning is enabled for release builds

[BrandonDyer64]

I disagree. I need to be able to use the conditioner in release mode.

It should be up to the developer to decide when and how the conditioner should be disabled.

[connorcarpenter]

Thank you for your feedback Brandon, fair enough 👍
May I ask why exactly you are wanting to use the link conditioner in release mode?

[BrandonDyer64]

My app uses video encoding, which is really only performant in release mode, and I use naia to send the compressed packets. It's definitely a good idea to prioritize keeping the conditioner out of production builds, but I would like to retain the option of having it enabled for --release.

I think it would be worthwhile (as an alternative) to include an example of how to disable it in the demos.

demos/bevy/shared/src/shared.rs

pub fn shared_config() -> SharedConfig<Channels> {
    // Set tick rate to ~60 FPS
    let tick_interval = Some(Duration::from_millis(20));

    // Use conditioner in debug mode
    #[cfg(debug_assertions)]
    let link_condition = Some(LinkConditionerConfig::average_condition());

    // Not in release mode
    #[cfg(not(debug_assertions))]
    let link_condition = None;

    SharedConfig::new(
        SocketConfig::new(link_condition, None),
        CHANNEL_CONFIG,
        tick_interval,
        None,
    )
}

[connorcarpenter]

Got it, thank you for the context! 👍