Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared LinkConditionerConfig #11

Open
smokku opened this issue Aug 30, 2020 · 2 comments
Open

Shared LinkConditionerConfig #11

smokku opened this issue Aug 30, 2020 · 2 comments
Labels
feature desired new functionality naia socket pertaining to naia_socket crates

Comments

@smokku
Copy link
Contributor

smokku commented Aug 30, 2020

Does LinkConditionerConfig belong to SharedConfig?

As I understand SharedConfig is a set of configuration that absolutely needs to be in sync between server and client in order for the network communication to work properly.

Link condition does not belong to this category. Usually this is the other way - server and client have really different network link reliability. It should be possible to configure different link condition in NaiaServer and NaiaClient.

@smokku
Copy link
Contributor Author

smokku commented Aug 30, 2020

If you agree, I can prepare a PR with this change.

@connorcarpenter
Copy link
Member

Hey Tomasz! Hey thanks for looking through naia in such detail, I love getting this feedback!

Yes, eventually I would like the LinkConditionerConfig to be specific to either the Client OR Server, like you say. The reason that it's in the SharedConfig right now is that the LinkConditioner currently buffers their INCOMING messages, but not OUTGOING messages. If both the Client & Server share the same link conditions, then we don't have to worry about buffering outgoing messages, because it'll be buffered once it arrives.

I would definitely like to change this, but opted for this solution as I was getting frustrated and wanted to move on to the clientside prediction stuff 👍 If you can add buffering to outgoing messages in naia-socket, then feel free to change this!

I will get to this eventually, if not.

@connorcarpenter connorcarpenter added naia socket pertaining to naia_socket crates feature desired new functionality labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature desired new functionality naia socket pertaining to naia_socket crates
Projects
None yet
Development

No branches or pull requests

2 participants