-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move addrList
allocation into setNodeID()
#221
Comments
I just thought of a reason: Allocating the array is dependent on the ID number passed to |
Maybe we can move the allocating code into |
I think those are probably both good ideas. |
addrList
allocation to c'toraddrList
allocation to seNodeID()
addrList
allocation to seNodeID()
addrList
allocation into setNodeID()
I'm only pursuing this proposal because it would obsolete the private member
addrMemAllocated
. Initially, this idea came to me (in #220) when discovering that static addresses have to be assigned after callingbegin()
. In order for a network administrator to give priority to statically assigned addresses, they'd have to assign the addresses before callingupdate()
; this proposal won't change that. However, the requirement for callingbegin()
feels a bit cumbersome as theaddrList
array has nothing to do with initializing the required hardware.I can't think of a reason to keep the allocating code in
begin()
, so maybe there's a historical reason about why it was written the way it is now.The proposed code change is pretty straight forward as mentioned in the issue title.
The text was updated successfully, but these errors were encountered: