Skip to content

Commit 7643124

Browse files
authored
refactor(iroh)!: Move blobs and tags rpc client and server to iroh-blobs (#2874)
## Description Move blobs and tags rpc client and server to iroh-blobs. Depends on n0-computer/iroh-blobs#7 Todo: - [x] merge n0-computer/iroh-blobs#7 ## Breaking Changes - Lots of types in client::blobs and client::tags become reexports - blob share goes away, since it requires the node client ## Notes & open questions I want to keep the client::blobs and client::tags modules self-contained, so the idea is that these will reexport all the things from iroh-blobs::rpc::client that a user will need (except I have probably forgotten something). Maybe I should use wildcard exports here even though people dislike them... ? ~~The client::blobs::Client itself is *not* a reexport but a newtype to hide the ugly type parameters. Same for client::tags::Client.~~ With the changes in quic-rpc, these are now just module reexports! The Blobs protocol handler now takes an Endpoint, since that was needed to implement one of the functions. <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All breaking changes documented.
1 parent 3be63bf commit 7643124

File tree

2 files changed

+21
-14
lines changed

2 files changed

+21
-14
lines changed

Cargo.lock

+20-13
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,6 @@ iroh-metrics = { path = "./iroh-metrics" }
5454
iroh-test = { path = "./iroh-test" }
5555
iroh-router = { path = "./iroh-router" }
5656

57-
iroh-blobs = { git = "https://github.com/n0-computer/iroh-blobs", branch = "main" }
5857
iroh-gossip = { git = "https://github.com/n0-computer/iroh-gossip", branch = "main" }
5958
iroh-docs = { git = "https://github.com/n0-computer/iroh-docs", branch = "main" }
59+
iroh-blobs = { git = "https://github.com/n0-computer/iroh-blobs", branch = "main" }

0 commit comments

Comments
 (0)