Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass calibration #93

Open
tomas-pluskal opened this issue Feb 16, 2016 · 3 comments
Open

Mass calibration #93

tomas-pluskal opened this issue Feb 16, 2016 · 3 comments

Comments

@tomas-pluskal
Copy link
Member

I would like to add a module for m/z calibration of peak lists based on compounds with known chemical formulas.

Something like this:

screen shot 2016-02-16 at 13 54 03

@dyrlund
Copy link
Member

dyrlund commented Feb 17, 2016

Good idea. What about also allowing to perform a RT calibration? This could for example be used to correct RT values based on internal standards before performing identification using a custom database.

And we could also consider quantile or bin calibration in addition to a full range calibration.

@photocyte
Copy link

I'd also add that it would be nice in all cases of calibration the "uncorrected" value (for RT m/z or whatever else), is saved within the data structure. My ideal case would be to have the data structure support the regeneration of a "workably identical" raw mzML file, including metadata, from the internal data representation, as well as a corrected mzML file containing the altered values if desired. Such manipulations should be clearly recorded in the mzML however.

@dyrlund
Copy link
Member

dyrlund commented Feb 29, 2016

This is already supported in the updated data structure in MSDK. So when you for example normalize the areas of features you will get a new column with the normalized areas while also preserving the original areas. In MZmine 2 only the normalized areas were stored.

With regards to the m/z and RT we probably need to allow some modules (like the identification modules) to either work on the original data or the corrected data (e.g. calibrated) if this is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants