You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You have an error in your non-max suppression implementation. You need to clamp your calculated dimensions of the bbox intersection at 0 (so they can't be negative) or else you can end up with a positive iou resulting from multiplying two negative dimensions. The positive iou may exceed the threshold even when the boxes don't intersect at all. This would happen if one bounding box fully sits both to the right and below another.
I think this should fix the problems referenced in #40 and #78. Going to submit a PR
The text was updated successfully, but these errors were encountered:
You have an error in your non-max suppression implementation. You need to clamp your calculated dimensions of the bbox intersection at 0 (so they can't be negative) or else you can end up with a positive iou resulting from multiplying two negative dimensions. The positive iou may exceed the threshold even when the boxes don't intersect at all. This would happen if one bounding box fully sits both to the right and below another.
I think this should fix the problems referenced in #40 and #78. Going to submit a PR
The text was updated successfully, but these errors were encountered: