Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS Error #84

Open
cnmckee opened this issue Aug 27, 2019 · 0 comments
Open

NMS Error #84

cnmckee opened this issue Aug 27, 2019 · 0 comments

Comments

@cnmckee
Copy link
Contributor

cnmckee commented Aug 27, 2019

You have an error in your non-max suppression implementation. You need to clamp your calculated dimensions of the bbox intersection at 0 (so they can't be negative) or else you can end up with a positive iou resulting from multiplying two negative dimensions. The positive iou may exceed the threshold even when the boxes don't intersect at all. This would happen if one bounding box fully sits both to the right and below another.
I think this should fix the problems referenced in #40 and #78. Going to submit a PR

@cnmckee cnmckee mentioned this issue Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant