Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“As user” option unnecessarily displayed to body users #5060

Open
jonkri opened this issue Jul 9, 2024 · 0 comments
Open

“As user” option unnecessarily displayed to body users #5060

jonkri opened this issue Jul 9, 2024 · 0 comments

Comments

@jonkri
Copy link
Contributor

jonkri commented Jul 9, 2024

Describe the bug

Body users' names are never displayed publicly on the site. It doesn't matter if the update is done via...

  • the inspect UI,
  • the normal flow with “as body” selected, or
  • the normal flow with “as user” selected.

Displaying both the “as body” and “as user” options to body users is unnecessary and can be confusing (they probably get the impression that they can post updates as “themselves”).

To Reproduce

Steps to reproduce the behavior:

  1. Create a body user
  2. Sign in as the body user
  3. Create a report or update within the boundaries of the body in question
  4. Note that the “as user” option is presented in the Report as dropdown

Expected behavior

I expect the “as user” option to not be present.

Screenshots

Not applicable.

Desktop (please complete the following information):

Not applicable.

Smartphone (please complete the following information):

Not applicable.

Additional context

If always_view_body_contribute_details hook is used then there would be a difference between “as body” or “as user”. However, since we are considering not using always_view_body_contribute_details anymore, and no other cobrand seems to be using the hook either, always_view_body_contribute_details may not need to be a consideration in this issue.

I'm not sure what the purpose of default_to_body is or how it would relate to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant