You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a problems with the newly included PJON library.
The addition seems to break the CI and let always fail the "Toll gate" step.
Details:
Toll gate (STM32F1 - Tests) — Warnings found
From Jenkins log:
In file included from /var/lib/jenkins/jobs/MySensors/jobs/MySensors/branches/PR-1488/workspace/MySensors/hal/transport/PJON/driver/PJON.h:62,
from /var/lib/jenkins/jobs/MySensors/jobs/MySensors/branches/PR-1488/workspace/MySensors/MySensors.h:397,
from /var/lib/jenkins/jobs/MySensors/jobs/MySensors/branches/PR-1488/workspace/MySensors/tests/Arduino/sketches/pjon_transport/pjon_transport.ino:24:
/var/lib/jenkins/jobs/MySensors/jobs/MySensors/branches/PR-1488/workspace/MySensors/hal/transport/PJON/driver/PJONDefines.h: In static member function 'static void PJONTools::parse_header(const uint8_t*, PJON_Packet_Info&)':
/var/lib/jenkins/jobs/MySensors/jobs/MySensors/branches/PR-1488/workspace/MySensors/hal/transport/PJON/driver/PJONDefines.h:415:31: warning: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'struct PJON_Packet_Info'; use assignment or value-initialization instead [-Wclass-memaccess]
415 | memset(&info, 0, sizeof info);
| ^
/var/lib/jenkins/jobs/MySensors/jobs/MySensors/branches/PR-1488/workspace/MySensors/hal/transport/PJON/driver/PJONDefines.h:207:8: note: 'struct PJON_Packet_Info' declared here
207 | struct PJON_Packet_Info {
| ^~~~~~~~~~~~~~~~
I assume that this memset(&info, 0, sizeof info); is not best practice and should be replaced.
The text was updated successfully, but these errors were encountered:
virtual-maker
changed the title
PJON driver produce warning and lets fail CI and Toll Gate
PJON driver produces warning and lets fail CI and Toll Gate
Jul 5, 2022
There is a problems with the newly included PJON library.
The addition seems to break the CI and let always fail the "Toll gate" step.
Details:
Toll gate (STM32F1 - Tests) — Warnings found
From Jenkins log:
I assume that this
memset(&info, 0, sizeof info);
is not best practice and should be replaced.The text was updated successfully, but these errors were encountered: