RFM69 FIFO Threshold Value

[erikjlane]

At this line:

MySensors/hal/transport/RFM69/driver/new/RFM69registers_new.h

Line 922 in aa76d26

#define RFM69_FIFOTHRESH_TXSTART_FIFONOTEMPTY 0x80 // Recommended default

It states that the recommended default for the FIFO Threshold is the FIFONOTEMPTY version of the constant.

However, when the setting is set, this recommendation is violated.

MySensors/hal/transport/RFM69/driver/new/RFM69_new.cpp

Line 736 in aa76d26

{ RFM69_REG_FIFOTHRESH, RFM69_FIFOTHRESH_TXSTART_FIFOTHRESH | (RFM69_HEADER_LEN - 1) }, // start transmitting when rfm69 header loaded, fifo level irq when header bytes received (irq asserted when n bytes exceeded)

Is there a reason for this that just didn't make it into the comments of the code, or is this an error and it should be corrected to use the 'not empty' setting for the FIFO?

I didn't want to do a pull request without being sure, and I also wasn't sure about such a minor revision.

But I'm figuring out all the differences so that I can use an Adafruit Radio Bonnet https://www.adafruit.com/product/4072 to monitor the messages being passed to do some troubleshooting. Their radio default modulation scheme is different, so I'm having to go in and tweak a number of them to make everything work. In the process I ran across this discrepancy. I fixed it in my local code, but having to change it for every time I pull the code to use with a new module would be a pain, and I would also prefer to not fork the library just for this.

Thanks!