Code maintenance (#1309)

* Fix issues after CPPcheck 1.88 update

* Code maintenance

.mystools/cppcheck/config/suppressions.cfg

@@ -1,13 +1,6 @@
 // inline suppression doesn't work
 *:hal/architecture/NRF5/drivers/Flash.cpp
-*:drivers/NVM/NVRAM.cpp
-*:hal\transport\RFM69\driver\old\RFM69_old.cpp
+*:hal/transport/RFM69/driver/old/RFM69_old.cpp
 // 3rd party
-*:hal/architecture/Linux/drivers/BCM/bcm2835.c
-*:hal/architecture/Linux/drivers/core/Client.h
-*:hal/architecture/Linux/drivers/core/EthernetClient.cpp
-*:hal/architecture/Linux/drivers/core/EthernetClient.h
-*:hal/architecture/Linux/drivers/core/EthernetServer.cpp
-*:hal/architecture/Linux/drivers/core/EthernetServer.h
-*:hal/architecture/Linux/drivers/core/SerialPort.h
-*:hal/architecture/Linux/drivers/core/StdInOutStream.h
+*:hal/architecture/Linux/*
+*:drivers/*

MyConfig.h

@@ -20,9 +20,8 @@
 /**
  * @file MyConfig.h
  * @ingroup MyConfigGrp
- *
  * @brief MySensors specific configuration flags.
- *
+ * @{
  * Set these in your sketch before including MySensors.h to customize the library to your needs.
  * If the sketch does not define these flags, they will get default values where applicable.
  */
@@ -1658,7 +1657,7 @@
 #ifndef MY_DEFAULT_LED_BLINK_PERIOD
 #define MY_DEFAULT_LED_BLINK_PERIOD 300
 #endif
-/** @}*/ // End of lEDSettingGrpPub group
+/** @}*/ // End of LEDSettingGrpPub group
 
 /**
  * @defgroup SecuritySettingGrpPub Security

core/MyGatewayTransport.cpp

@@ -29,26 +29,25 @@ inline void gatewayTransportProcess(void)
 {
 	if (gatewayTransportAvailable()) {
 		_msg = gatewayTransportReceive();
-		if (_msg.destination == GATEWAY_ADDRESS) {
+		if (_msg.getDestination() == GATEWAY_ADDRESS) {
 
 			// Check if sender requests an echo
-			if (mGetRequestEcho(_msg)) {
+			if (_msg.getRequestEcho()) {
 				// Copy message
 				_msgTmp = _msg;
 				// Reply without echo flag, otherwise we would end up in an eternal loop
-				mSetRequestEcho(_msgTmp,
-				                false);
-				mSetEcho(_msgTmp, true);
-				_msgTmp.sender = getNodeId();
-				_msgTmp.destination = _msg.sender;
+				_msgTmp.setRequestEcho(false);
+				_msgTmp.setEcho(true);
+				_msgTmp.setSender(getNodeId());
+				_msgTmp.setDestination(_msg.getSender());
 				gatewayTransportSend(_msgTmp);
 			}
-			if (mGetCommand(_msg) == C_INTERNAL) {
-				if (_msg.type == I_VERSION) {
+			if (_msg.getCommand() == C_INTERNAL) {
+				if (_msg.getType() == I_VERSION) {
 					// Request for version. Create the response
 					gatewayTransportSend(buildGw(_msgTmp, I_VERSION).set(MYSENSORS_LIBRARY_VERSION));
 #ifdef MY_INCLUSION_MODE_FEATURE
-				} else if (_msg.type == I_INCLUSION_MODE) {
+				} else if (_msg.getType() == I_INCLUSION_MODE) {
 					// Request to change inclusion mode
 					inclusionModeSet(atoi(_msg.data) == 1);
 #endif

core/MyGatewayTransportMQTTClient.cpp

@@ -119,8 +119,8 @@ bool gatewayTransportSend(MyMessage &message)
 	char *topic = protocolMyMessage2MQTT(MY_MQTT_PUBLISH_TOPIC_PREFIX, message);
 	GATEWAY_DEBUG(PSTR("GWT:TPS:TOPIC=%s,MSG SENT\n"), topic);
 #if defined(MY_MQTT_CLIENT_PUBLISH_RETAIN)
-	const bool retain = mGetCommand(message) == C_SET ||
-	                    (mGetCommand(message) == C_INTERNAL && message.type == I_BATTERY_LEVEL);
+	const bool retain = message.getCommand() == C_SET ||
+	                    (message.getCommand() == C_INTERNAL && message.getType() == I_BATTERY_LEVEL);
 #else
 	const bool retain = false;
 #endif /* End of MY_MQTT_CLIENT_PUBLISH_RETAIN */