Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Myparcel module breaks payload-extender functionality #774

Closed
ainigma32 opened this issue Sep 21, 2023 · 2 comments · Fixed by #775
Closed

Myparcel module breaks payload-extender functionality #774

ainigma32 opened this issue Sep 21, 2023 · 2 comments · Fixed by #775
Labels
bug Something isn't working released

Comments

@ainigma32
Copy link
Contributor

Plugin version

4.10.0

Magento version

2.4.6

PHP version

8.1

What went wrong?

Modules that try to use the payload-extender functionality are not working because Myparcel overrides the Magento_Checkout/js/model/shipping-save-processor/default component but it does not call the payload-extender component.

Reproduction steps

  1. Install a module that uses the payload-extender functionality (e.g. ulmod/module-checkoutnewslettersubscription)
  2. Navigate to checkout
  3. Check the loaded JS resources
  4. See that the payload-extender file is not loaded

Relevant log output

No response

Additional context

No response
@ainigma32 ainigma32 added the bug Something isn't working label Sep 21, 2023
@ainigma32 ainigma32 mentioned this issue Sep 21, 2023
Merged
@ainigma32
Copy link
Contributor Author

Added a PR to fix this #775

@MyParcelBot
Copy link

🎉 This issue has been resolved in version 4.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(checkout): restore payload extender functionality ainigma32/myparcelnl
3 participants
@ainigma32 @RichardPerdaan @MyParcelBot