Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Alpha 1 ACP Configuration + Settings #176

Open
1 task done
wpillar opened this issue Aug 30, 2015 · 4 comments
Open
1 task done

Alpha 1 ACP Configuration + Settings #176

wpillar opened this issue Aug 30, 2015 · 4 comments
Milestone

Comments

@wpillar
Copy link
Contributor

wpillar commented Aug 30, 2015

  • Alter all available settings from the ACP.
@wpillar
Copy link
Contributor Author

wpillar commented Aug 30, 2015

@mybb/developers anything else to add here? Do we even have a table for settings / configuration yet? Do we even have any settings?

@euantorano
Copy link
Member

Yep, we've got settings. You have to publish the migration from the settings package to get the table.

On 30 Aug 2015, at 16:17, Will Pillar [email protected] wrote:

@mybb/developers anything else to add here? Do we even have a table for settings / configuration yet? Do we even have any settings?


Reply to this email directly or view it on GitHub.

@wpillar
Copy link
Contributor Author

wpillar commented Aug 31, 2015

@euantorano ah of course, but we do need to expose those to editing in the ACP?

@euantorano
Copy link
Member

@wpillar I think so, but I'm considering changing the settings lib a bit.

IMO, the main Manager should just handle reading settings, whilst changing them should be done using a SettingsRepository. This would simplify the whole Manager class and make it fit more inline with the rest of the core.

If everybody agrees, I'm going to fix that this week and hopefully open the Settings library to the public next weekend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants