-
Notifications
You must be signed in to change notification settings - Fork 45
Add main.min.css and main.min.js to gitignore #154
Comments
👍 no compiled files should be committed to the repository imho. |
The reason they were committed was so that not everybody would need node, bower, gulp etc set up.
|
We use main.js and main.css and vendor.js now, minified files can make merge conflicts for now.... |
@euantorano when you say 'everybody' do you mean developers or users? |
I mean developers and SQA team members. Not everybody needs to be able to do work on front end stuff.
|
If we set it up properly, it would be no more difficult than:
Done. I'd rather that than the conflicts we have now to be honest. |
True.
|
We should add
public/assets/css/main.min.css
,public/assets/css/rtl.min.css
,public/assets/js/main.js.min.map
,public/assets/js/vendor.js.min.map
,public/assets/js/main.min.js
andpublic/assets/js/vendor.min.js
to.gitignore
...these files make merge conflicts usually and we don't use them now... (https://github.com/mybb/mybb2/blob/master/resources/views/footer/footer.twig#L17-L18 & https://github.com/mybb/mybb2/blob/master/resources/views/partials/headerinclude.twig#L7,L9 )
The text was updated successfully, but these errors were encountered: