Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Escape language strings for JS #136

Open
Destroy666x opened this issue May 10, 2015 · 3 comments
Open

Escape language strings for JS #136

Destroy666x opened this issue May 10, 2015 · 3 comments

Comments

@Destroy666x
Copy link
Contributor

As I suggested under my lang commit, there should be some sort of support for languages which are often using apostophes (for example French) so that JS errors don't happen. Simply escaping them with Twig should be fine.

@JN-Jones
Copy link
Contributor

There's only that "delete confirmation" dialog where this applies atm, isn't it? That one should be left for now as we'll likely use a modal/dialog instead of a js popup.
But generally, yes, this should be added for sure.

@ATofighi
Copy link
Contributor

I think it is fixed in 260cf6c

@Destroy666x
Copy link
Contributor Author

#159 seems to fix it indeed, at least the current lang strings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants