Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

Enhance code review process with Travis CI #34

Open
dmvass opened this issue May 8, 2018 · 3 comments
Open

Enhance code review process with Travis CI #34

dmvass opened this issue May 8, 2018 · 3 comments
Assignees

Comments

@dmvass
Copy link
Collaborator

dmvass commented May 8, 2018

Hello @myarik!

Can you please add travis ci integration for this repo. I have already created travis ci configuration file in the root and tested it with fork. I hope it's very improve our code review process.

Best regards.

@myarik
Copy link
Owner

myarik commented May 18, 2018

Hi, @kandziu

I added the Travis ci integration but looks like one test is not passed

@dmvass
Copy link
Collaborator Author

dmvass commented May 18, 2018

@myarik can you give me a link to the failed test please?

@myarik
Copy link
Owner

myarik commented May 21, 2018

tests/test_filters.py ......................................             [ 30%]
tests/test_mixins.py .......                                             [ 36%]
tests/test_pagination.py ........                                        [ 42%]
tests/test_serializers.py ........                                       [ 48%]
tests/test_validators.py ..............................................  [ 85%]
tests/test_views.py .............F....                                   [100%]
=================================== FAILURES ===================================
________ TestElasticAPIView.test_filter_search[query_params3-expected3] ________
tests/test_views.py:151: in test_filter_search
    assert sorted(result) == sorted(expected)
E   assert [2, 5, 6, 8, 10, 12] == [2, 6, 8, 10]
E     At index 1 diff: 5 != 6
E     Left contains more items, first extra item: 10
E     Use -v to get the full diff
===================== 1 failed, 124 passed in 8.37 seconds =====================
ERROR: InvocationError for command '/home/travis/build/myarik/django-rest-elasticsearch/.tox/drf34-py27-dj108-esdsl5/bin/python setup.py test' (exited with code 1)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants