Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be possible to generate requirements.txt file? #1063

Closed
fabcor-maxiv opened this issue Oct 28, 2024 · 4 comments
Closed

Would it be possible to generate requirements.txt file? #1063

fabcor-maxiv opened this issue Oct 28, 2024 · 4 comments

Comments

@fabcor-maxiv
Copy link
Contributor

fabcor-maxiv commented Oct 28, 2024

Would it be possible to generate requirements.txt files in parallel with / from the pyproject.toml and poetry.lock files? This would allow people to work with non-poetry installations and make it easier (for some, at least) to deal with problems like the one I came across here (#1061).

Originally posted by @rhfogh in #1061 (comment)

@fabcor-maxiv
Copy link
Contributor Author

@rhfogh, for confirmation, what would you like to see in this requirements.txt file?

  • Only the direct dependencies with loose version constraints as in pyproject.toml?
  • All dependencies, including indirect dependencies with pinned versions as in poetry.lock?

@rhfogh
Copy link
Collaborator

rhfogh commented Oct 28, 2024

@marcus-oscarsson Not sure I know enough to give a good answer. Basically that you can put those requirements.txt files to pip or conda, get a full installation that way, and get something that works. In my normal way of working I would generally be happy with loose constraints and only pin versions if there was a specific reason that things would break otherwise. But you guys, understanding the installation procedure better than I do, might have something to say, here.

@fabcor-maxiv
Copy link
Contributor Author

I feel like the best solution would be for you to curate your own file.

If I understood correctly from one of your other messages, you also want to have the mxcube parts installed as editable, right?

If you go with conda, it could be as simple as something like this:

dependencies:
  - python=3.8
  - python-ldap=3.4.3
  - pip
  - pip:
    - --editable path/to/mxcubecore
    - --editable path/to/mxcubeqt

The tricky part is that not everyone has the same paths on their local filesystem, so we can not share this file in the GitHub repository.

I tested this briefly and it seems to work. We can probably refine after some iterations.

@rhfogh
Copy link
Collaborator

rhfogh commented Oct 28, 2024

@fabcor-maxiv Great! That solved the problem (with a little extra experimentation). The result in in mxcubeqt PR #462.

I shall close the issue now. the mxcubeweb install already worked fine, and this takes care of mxcubeqt much simpler than by adding extra requirements files and fiddling around with that.

Question withdrawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants