Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with httpx 0.28.0 #1446

Open
decaz opened this issue Nov 29, 2024 · 2 comments · May be fixed by #1447
Open

Incompatibility with httpx 0.28.0 #1446

decaz opened this issue Nov 29, 2024 · 2 comments · May be fixed by #1447

Comments

@decaz
Copy link

decaz commented Nov 29, 2024

Since version 0.28.0 of httpx The deprecated proxies argument has now been removed.:

self.wsdl_client = wsdl_client or httpx.Client(
verify=verify_ssl,
proxies=proxy,
timeout=timeout,
)
self.client = client or httpx.AsyncClient(
verify=verify_ssl,
proxies=proxy,
timeout=operation_timeout,
)

@decaz decaz changed the title Incompatibilty with httpx Incompatibilty with httpx 0.28.0 Nov 29, 2024
@decaz decaz changed the title Incompatibilty with httpx 0.28.0 Incompatibility with httpx 0.28.0 Nov 30, 2024
@TB99930
Copy link

TB99930 commented Dec 11, 2024

If anyone is experiencing this problem, simply fix your version of httpx, using an exact version pre-0.28 or the qualifier <0.28 until the attached PR is merged.

For example: httpx>=0.26,<0.28 or httpx==0.27.2

@ba1dr
Copy link

ba1dr commented Dec 11, 2024

If anyone is experiencing this problem, simply fix your version of httpx, using an exact version pre-0.28 or the qualifier <0.28 until the attached PR is merged.

For example: httpx>=0.26,<0.28 or httpx==0.27.2

I think this is a bad solution, as other libraries may require newer version or have another constraint.
Perhaps we can just initialize clients outside and pass to the Transport's constructor:

wsdl_client = httpx.Client(
    verify=sslcontext,
    timeout=HTTP_TIMEOUT,
)
httpx_client = httpx.AsyncClient(verify=sslcontext,
                                 timeout=HTTP_TIMEOUT)
transport = AsyncTransport(client=httpx_client, wsdl_client=wsdl_client)
zclient = ZeepClient(
    wsdl_file, transport=transport,
    service_name=bind_soap_service, port_name=bind_soap_port
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants