Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if a slice contains too many NaN values #1

Open
saimn opened this issue Mar 9, 2018 · 0 comments
Open

Warn if a slice contains too many NaN values #1

saimn opened this issue Mar 9, 2018 · 0 comments

Comments

@saimn
Copy link
Member

saimn commented Mar 9, 2018

Zap cleans the NaN values before doing the PCA (Spaxels with more then 25% of NaN values are removed, the others are replaced with an interpolation from the neighbors.) but this does not take into account specific cases where a slice of the cube has many NaNs, typically at the beginning or end of the cube.
This may lead to unexpected results because of the interpolation on these pixels, so it would be useful to at least emit a warning when a slice has more than x % of NaNs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant