Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow written tempo when 'c.' added to tempo text #24596

Closed
2 tasks done
Christof1981 opened this issue Sep 9, 2024 · 6 comments · Fixed by #24612
Closed
2 tasks done

Follow written tempo when 'c.' added to tempo text #24596

Christof1981 opened this issue Sep 9, 2024 · 6 comments · Fixed by #24612
Assignees
Labels
community Issues particularly suitable for community contributors to work on feature request Used to suggest improvements or new capabilities good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute

Comments

@Christof1981
Copy link

Your idea

  1. Create a tempo, i.e., crotchet = 80.
  2. Add a 'c.' to the text, indicating 'circa', so it's crotchet = c. 80.
  3. Now change the number, i.e., crotchet = c. 100.

MuseScore will still play it at 80, and in order for it to be played at 100, it is necessary to override the written tempo. My idea is that the tempo text should be more easily customisable so MuseScore will still read the tempo with the addition of text.

Problem to be solved

The problem is the lack of customisation, and the ability to make tempo text appear as you want it to and play at the correct tempo while removing the extra step of overriding the written tempo.

Prior art

No response

Additional context

No response

Checklist

  • This request follows the guidelines for reporting issues
  • I have verified that this feature request has not been logged before, by searching the issue tracker for similar requests
@muse-bot muse-bot added the feature request Used to suggest improvements or new capabilities label Sep 9, 2024
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 9, 2024

Stems from https://musescore.org/en/node/368458

I think this actually is a bug, as "crotchet = ca. 80" doesn't have that problem

Which then also is the workaround: use "ca." rather than "c."

@cbjeukendrup cbjeukendrup added good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute community Issues particularly suitable for community contributors to work on labels Sep 10, 2024
@pacebes
Copy link
Contributor

pacebes commented Sep 10, 2024

Hi

I am looking for a good first issue. I would like to give it a try!

Thanks

@Jojo-Schmitz
Copy link
Contributor

Check

s.replace(u"ca.", u"");
;-)

@oktophonie oktophonie moved this from Available to Tentatively in progress in Community Projects Sep 10, 2024
@pacebes
Copy link
Contributor

pacebes commented Sep 10, 2024

Thanks

I have been looking in this method as you suggest and there are several replacements:

s.replace(u",", u".");
s.replace(u"<sym>space</sym>", u" ");
s.replace(u"≒", u"=");
s.replace(u"≈", u"=");
s.replace(u"~", u"=");
s.replace(u"ca.", u"");
s.replace(u"approx.", u"");

I think the easy way is to add something like:

s.replace(u"c.", u"");

I don't know if there are any additional texts that should be supported. Is it just "c." ?

Kind regards

@Jojo-Schmitz
Copy link
Contributor

I'd stick with that one extra line for now

@pacebes
Copy link
Contributor

pacebes commented Sep 10, 2024

Ok

pacebes added a commit to pacebes/MuseScore that referenced this issue Sep 10, 2024
@oktophonie oktophonie moved this from Tentatively in progress to In progress in Community Projects Sep 10, 2024
cbjeukendrup added a commit that referenced this issue Sep 12, 2024
Fix #24596: Adding "c. " text support  within Tempo text
@github-project-automation github-project-automation bot moved this from In progress to Done in Community Projects Sep 12, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this issue Sep 12, 2024
RomanPudashkin added a commit that referenced this issue Sep 12, 2024
[4.4.2] Fix #24596: Adding "c. " text support  within Tempo text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues particularly suitable for community contributors to work on feature request Used to suggest improvements or new capabilities good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants