Menu Navigation not working with Left/Right arrows (behave like Up/Down arrows) #19987
Comments
|
@DmitryArefiev pls look at this one |
|
I would like to take this issue but I would need more info about the expected behavior. For example, when you use right arrow in a submenu on an option that does not have an submenu should it move directly to the next app menu? |
|
@NinjaNas, judging by the behaviour of MS Paint and Notepad, no, pressing Right in a submenu should not take you to the next top-level menu. However, it does in Firefox, so I'd say that it doesn't really matter either way. The main thing is that pressing Right in a top-level menu should take you to the next top-level menu. |
|
@shoogle I just tested this out in Notepad and it does take you to the new top-level menu. Alt + V, then Right Arrow twice should put you into the Zoom submenu and then to the Help menu. I personally think it should go to the next top-level menu, otherwise Right Arrow has the the same functionality has Down Arrow in this case. |
|
@NinjaNas, I'm on Windows 11 and my Notepad doesn't have a Help menu. Maybe you're on Windows 10 or using Notepad++? 
Anyway, in Notepad on Windows 11 the Right arrow key behaves as I described (i.e. it does nothing in submenus), though like I said before, I don't have a problem with it putting you on the next menu. The Right arrow shouldn't behave like the Down arrow in menus. It should either put you on the next menu or do nothing. It shouldn't put you on the next item in the current menu. |
|
Got it. Also, I am on Windows 10 where the notepad app is different. |
|
Preference in the accessibility review info I've been given by RNIB (Royal National Institute for the Blind) and also my personal preference would be for right arrow when in a sub menu to as described above jump to the top of the next menu. Otherwise if there are a lot of sub menus in a column it can be hard to find a quick way to move right, having to back out of each sub menu with a left arrow and move down and try to move right again. Screen reader users will be used to this behaviour and not confused by it moving from a sub menu to the top of the next menu. But as peter said the most important thing is that right arrow should only navigate to the right and never down the list and there needs to be a way to move right from menu to menu, otherwise if you can't remember what all the menus are or what the shortcuts are there is no way to browse through them. |
|
Currently, I got the menu to close correctly in StyleMenu.qml, however, I am not sure how to send a signal over to AppMenuBar.qml so I can run a function to jump directly to the next app menu. If you have any tips or a better suggestion, let me know. |
|
I agree with all the proposed improvements. Another example supporting the navigation to the next menu is that macOS navigation works exactly that way. I also notice that navigation from submenus is also available in macOS, so it would be great to implement this in MuseScore. @NinjaNas, all navigation logic is stored in the NavigableAppMenuModel class. There shouldn't be any issues with closing all menus when pressing the right/left arrow keys, but I could be mistaken. |
There was an issue with right arrow not closing the menu but that is an easy fix. From what I can tell
The problem is when the dropdown menu closes because of a left/right arrow on a non-submenu item, it should also navigate the NavigableAppMenuModel to the next menu and open it. Currently, my question is what is the best way of doing this as it seems I need the two menus to interact with each other. I'm pretty new to Qt and QML so I was just thinking of trying to pass a signal to NavigableAppMenuModel when the downdown menu closes after left/right arrow (though I don't know where I would put the QObject::connect()). I wanted to know if I'm headed in the right direction or if I should look for a different solution. |
|
@NinjaNas, best thing to do is find any method that works (or nearly works) and then submit a PR. This way we know you're serious about fixing it, and if it's not the right solution we at least have a starting point from which we can point you in the right direction. |
Add a force close upon using Right Arrow on a non-submenu item Use signals when appropriate to invoke jumpToNextMenu in the correct direction
Add a force close upon using Right Arrow on a non-submenu item Use signals when appropriate to invoke openPrevMenu/openNextMenu Add hasSiblingMenus property to allow context menus using the StyledMenu class to be closed using left/right arrow key
Add a force close upon using Right Arrow on a non-submenu item Use signals when appropriate to invoke openPrevMenu/openNextMenu Add hasSiblingMenus property to allow context menus using the StyledMenu class to be closed using left/right arrow key
Add a force close upon using Right Arrow on a non-submenu item Use signals when appropriate to invoke openPrevMenu/openNextMenu Add hasSiblingMenus property to allow context menus using the StyledMenu class to be closed using left/right arrow key
Add a force close upon using Right Arrow on a non-submenu item Use signals when appropriate to invoke openPrevMenu/openNextMenu Add hasSiblingMenus property to allow context menus using the StyledMenu class to be closed using left/right arrow key
Add a force close upon using Right Arrow on a non-submenu item Use signals when appropriate to invoke openPrevMenu/openNextMenu Add hasSiblingMenus property to allow context menus using the StyledMenu class to be closed using left/right arrow key
DmitryArefiev
changed the title
Add a force close upon using Right Arrow on a non-submenu item Use signals when appropriate to invoke openPrevMenu/openNextMenu Add hasSiblingMenus property to allow context menus using the StyledMenu class to be closed using left/right arrow key
Add a force close upon using Right Arrow on a non-submenu item Use signals when appropriate to invoke openPrevMenu/openNextMenu Add hasSiblingMenus property to allow context menus using the StyledMenu class to be closed using left/right arrow key
Fix #19987 Menu Navigation not working with Left/Right arrows
github-project-automation
bot
moved this from In progress
to Needs porting
in MuseScore Studio 4.4
Fix musescore#19987 Menu Navigation not working with Left/Right arrows
|
This is unfortunately not working correctly with NVDA. STEPS:
|
|
@jmwmusic Oh I see, it became more serious for NVDA when using new behavior with Left/Right arrows. Please log a separate ticket for "blank" issue with NVDA and assign it to me. Also, it still works when using previous behavior: when exit from sub-menu list with Esc, navigate through menu group (e.g. from File to Edit), then enter group with Enter or Down arrow and navigate through sub-menu list The initial PR #20191 fixed only navigation issue (not accessibility part) see #20191 (comment) and #20191 (comment) I've logged a separate accessibility issue for Narrator and Orca #24151 |
|
@DmitryArefiev I already made an issue #22883. Please update if needed! |
|
@NinjaNas Oh thanks! I'll just add a case from the comment below |
Issue type
UI bug
Bug description
When using keyboard navigation in menus the left/right arrows do not open the next menu.
Steps to reproduce
Expected behaviur is for it to move focus onto and open the next menu so you should year Edit/Undo. Instead it moves down the next item in the file menu and then gets somewhat stuck.
Screenshots/Screen recordings
No response
MuseScore Version
4.1
Regression
I don't know
Operating system
Window 10 with NVDA
Additional context
No response
The text was updated successfully, but these errors were encountered: