-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undefined symbol: EVP_MAC_fetch in Electron on Linux #172
Comments
Hello, |
I mean on ci |
That's a good question, I'm not sure. It runs on The yml file is here in case anything obvious jumps out at you. |
Not sure about the OpenSSL version of the latest version. Could you pls try with ubuntu-20 |
And I can not see the full log? Is it normal? |
I've tried with
I'm not sure what other logging there is supposed to be? Do I need to set an env var or something? |
I can see the logs now. Is there any test with nodejs that passed? |
Sorry for the delay in my replying - yes, the test suite runs on nodejs without error, the error only occurs on the electron main process. I know electron bundles it's own version of node with extra patches (18.16 at the time of writing) - looks like it uses BoringSSL over OpenSSL as well - could this be the cause? |
Yes, a mismatch between OpenSSL and BoringSSL may well be the cause. @murat-dogan It looks like we don't hide symbols so the OpenSSL symbols end up re-exported by |
Here I am already working on a electron example project. It is not ready to merge. I can build and run it without any problem. I don't re-build it for electron, it just works. |
If you enable But if you run The the bad part is |
Solution 1Please check https://github.com/murat-dogan/node-datachannel/tree/electron-demo branch In For electron binary needs to be rebuilt. But as I said So I created a simple plugin for Please check the demo and plugin. With NAPICould you please try also this release without recompiling or the plugin above? It is napi based and should also work without recompiling. |
I have just release Version 0.5.0-dev It consists electron-demo project also |
Progress! With the 0.5.0-dev release the tests now pass! Unfortunately it crashes after the test run with:
This is the build: https://github.com/libp2p/js-libp2p/actions/runs/6432905404/job/17478596409?pr=1918 |
There are some other error messages on the log. Are they related? Is it an option for you to run tests locally? |
Any update on this, or should I close the issue? |
No, unfortunately it still crashes after the test run. Here's a recent test run.
Locally on Mac OS X it fails too, though without the extra info:
|
I cloned the repo and tried to re-produce it.
|
Thanks for investigating. It's a monorepo project with cross-dependencies between the package siblings. From the output it looks like you've run You need to build the project before running tests. In the root of the repo run: $ npm run build After that the test command should run. |
Now I can run the test.
|
This is full output of the main test (but no webrtc)
|
Ah, sorry - they are disabled right now because they fail in CI. I should have pasted the below. After installing and building in the root you can run just the relevant WebRTC tests with electron-main with: % cd packages/transport-webrtc
% npx aegir test -t electron-main |
Thanks for guiding me. It seems there are 2 problems. The second thing is as I understood test is waiting for a clear exit. Then you should call the cleanup function somewhere.
I am releasing latest changes. So you can try it. |
I did some debugging on tests with the latest version. Is it a solution for you? Wİth this patch it passes
|
Yes! User error is the best kind of error 😅 . Thanks for looking in to this. |
I'm seeing this error on Electron in GitHub actions:
Weirdly I can't replicate it locally on Linux or Mac OS X.
Here is the CI run: https://github.com/libp2p/js-libp2p/actions/runs/5692383157/job/15429456572?pr=1905
The text was updated successfully, but these errors were encountered: