Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #17

Open
muodov opened this issue Dec 30, 2015 · 2 comments
Open

Code cleanup #17

muodov opened this issue Dec 30, 2015 · 2 comments

Comments

@muodov
Copy link
Owner

muodov commented Dec 30, 2015

Since kociemba initially was a direct translation from java, the code inherited some awkward places in design. For example, in some places python list elements are iterated by index. Also, decomposition might be improved.

These need to be fixed to keep the project healthy.

@ansiwen
Copy link
Contributor

ansiwen commented Dec 30, 2015

Also the C api doesn't look very consistent... I personally would prefer a C++ library anyways, with an python wrapper around it. I guess in the midterm keeping two libraries in sync will not be feasible.

@muodov
Copy link
Owner Author

muodov commented Dec 30, 2015

Yep, I agree, C implementation definitely needs some care, at the moment it is more like a working PoC than a proper library. And C implementation is surely more important since solving the cube is performance-bound. Pure Python version might be deprecated in future, but it is working now and there are some cases when it is handy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants