-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot disable Echo Cancellation through Audio Wizard unless explicitly ticked and unticked #6544
Labels
Comments
StrangePeanut
added
bug
A bug (error) in the software
triage
This issue is waiting to be triaged by one of the project members
labels
Aug 27, 2024
Can confirm. Reproducible when having an established client configuration with echo cancellation enabled. The audio wizard will not take the active echo cancellation setting into account and show an unchecked checkbox. Offending code is probably in here: mumble/src/mumble/AudioWizard.cpp Lines 47 to 60 in 4610353
|
Hartmnt
added
client
ui
good first issue
Good for first-time contributors
and removed
triage
This issue is waiting to be triaged by one of the project members
labels
Sep 13, 2024
Hartmnt
added a commit
to Hartmnt/mumble
that referenced
this issue
Oct 15, 2024
The echo cancellation checkbox had two separate, but similar problems: 1) It would never load in a checked state when you open up the AudioWizard 2) It would also never load the correct checked state representing the user settings when switching AudioInput or AudioOutput systems. The first problem can be traced back to commit 0104375 where the state of qcbEcho depends on the selected element of the AudioOutput dropdown menu, before it has been filled. The second problem probably goes back to 2991d20 where the enabled state of the qcbEcho checkbox was changed on changing audio systems, but the checked state was not reloaded. This commit refactors the code (swaps initializing input and output) and adds a shared method to update the qcbEcho checkbox appropriately. Fixes mumble-voip#6544
Hartmnt
added a commit
to Hartmnt/mumble
that referenced
this issue
Oct 15, 2024
The echo cancellation checkbox had two separate, but similar problems: 1) It would never load in a checked state when you open up the AudioWizard 2) It would also never load the correct checked state representing the user settings when switching AudioInput or AudioOutput systems. The first problem can be traced back to commit 0104375 where the state of qcbEcho depends on the selected element of the AudioOutput dropdown menu, before it has been filled. The second problem probably goes back to 2991d20 where the enabled state of the qcbEcho checkbox was changed on changing audio systems, but the checked state was not reloaded. This commit refactors the code (swaps initializing input and output) and adds a shared method to update the qcbEcho checkbox appropriately. Fixes mumble-voip#6544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
Discovered a bug whilst helping my mate set up Mumble last night.
The Echo Cancellation option in the Audio Wizard does not take effect when left unticked with the intention to disable the feature. To disable Echo Cancellation through the Audio Wizard, one needs to explicitly tick and untick the option. Enabling Echo Cancellation does work as intended.
Steps to reproduce
Reproducible on fresh and existing installs.
Scenario 1 (fresh install)
Scenario 2
Mumble version
1.5.634
Mumble component
Client
OS
Windows
Reproducible?
Yes
Additional information
No response
Relevant log output
No response
Screenshots
No response
The text was updated successfully, but these errors were encountered: