-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested fix for ReturnsNewTokenIdentifier #1752
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrei Vasilescu <[email protected]>
JustEatAnApple
requested review from
andrei-marinica,
BiancaIalangi and
mihaicalinluca
August 28, 2024 09:36
Coverage SummaryTotals
FilesExpand
|
Contract comparison - from 02f3c9c to 88a84e3
|
BiancaIalangi
previously approved these changes
Aug 28, 2024
mihaicalinluca
previously approved these changes
Aug 28, 2024
Co-authored-by: Andrei Vasilescu <[email protected]>
Co-authored-by: Andrei Vasilescu <[email protected]>
andreivasilescu24
dismissed stale reviews from mihaicalinluca and BiancaIalangi
via
August 29, 2024 12:57
88a84e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.returns(ReturnsNewTokenIdentifier) was not working for all issuance commands in another PR so we suggest this change as a fix (we have tested the returns with this code and it worked)