Editor: rotation #515
Merged
Editor: rotation #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congrats 🎉! |
|
It works for the most part, but the object gets flipped at -90 on Y axis if treshold returns values near -0.5. elseif treshold < -0.499 then
return {math.deg(2 * math.atan2(q1, q0)), -90, 0}Great job anyways!! |
It was done this way on purpose, to deal with problems caused by gimbal lock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the logic of converting from quaternion to Euler, thus eliminating previously discovered rotation issues.
Thus fixes #496
Explanation
The issue originates from the logic of the
getEulerFromQuatfunction, which was fixed by handling euler singularities.The function has been refactored above for easier readability.