To more easily test the singlehop scenario you need to turn off the "smart routing" that's behind the debug flags in single hop picker in RelaySelectorPicker.swift.

Reviewable status: 0 of 8 files reviewed, all discussions resolved

Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rablador)

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsInteractor.swift line 59 at r2 (raw file):

        var tunnelSettings = tunnelSettings
        tunnelSettings.daita = settings

Is this not mutating the instance variable tunnelSettings?

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift line 227 at r2 (raw file):

        case .daitaSettingIncompatibleWithMultihop:
            """
            DAITA isn’t available on the current entry server. After enabling, please go to \

Should this not be 2 different NSLocalizedStrings?

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pinkisemils)

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsInteractor.swift line 59 at r2 (raw file):

No, self.tunnelSettings is a struct, so it'll be copied on assignment.

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift line 227 at r2 (raw file):

These strings are used in localized strings in AlertPresentation below. I didn't want to make them both NSLocalizedString because it bloats the function body somewhat.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pinkisemils)

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsInteractor.swift line 59 at r2 (raw file):

No, I'm wrong.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pinkisemils)

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsInteractor.swift line 59 at r2 (raw file):

No, I'm right. :D

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pinkisemils)

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsInteractor.swift line 59 at r2 (raw file):

Since .daita prop is a struct too it's assigned as a copy. Had .daita prop been a class it would have been as you say.

Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @pinkisemils and @rablador)

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsInteractor.swift line 61 at r2 (raw file):

        tunnelSettings.daita = settings

        let selectedRelays = try? tunnelManager.selectRelays(tunnelSettings: tunnelSettings)

We're starting to add quite some logic in that interactor, I think it would be nice to have some tests for it.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsInteractor.swift line 61 at r2 (raw file):

Do you want it to be done in this PR? (since it has already been approved by two reviewers)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsInteractor.swift line 61 at r2 (raw file):

We can leave it for another PR since we're bug bashing it tomorrow

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsInteractor.swift line 61 at r2 (raw file):

Done.