script: LoadBlocker's drop impl shouldn't run after termination.

The logic in LoadBlocker::terminate was modified in servo#34122 to `clone`
the LoadBlocker's inner `load` member instead of `take`ing it. However,
this member serves as a flag so that `LoadBlocker`'s Drop impl can avoid
calling `doc.finish_load` on already terminated loads. The change in
unnecessary 'unknown completed load' warnings when Servo is run with
logging enabled.

This patch also updates the expectations for tests which started passing
after the change in servo#34122, but now fail again with this change. These
test failures will be investigated in servo#36561.

Signed-off-by: Mukilan Thiyagarajan <[email protected]>

Author: mukilan

components/script/document_loader.rs

@@ -50,10 +50,18 @@ impl LoadBlocker {
 
     /// Remove this load from the associated document's list of blocking loads.
     pub(crate) fn terminate(blocker: &DomRefCell<Option<LoadBlocker>>, can_gc: CanGc) {
-        if let Some(this) = blocker.borrow().as_ref() {
-            let load_data = this.load.clone().unwrap();
-            this.doc.finish_load(load_data, can_gc);
+        let Some(load) = blocker
+            .borrow_mut()
+            .as_mut()
+            .and_then(|blocker| blocker.load.take())
+        else {
+            return;
+        };
+
+        if let Some(blocker) = blocker.borrow().as_ref() {
+            blocker.doc.finish_load(load, can_gc);
         }
+
         *blocker.borrow_mut() = None;
     }
 }

tests/wpt/meta/dom/ranges/Range-cloneContents.html.ini

@@ -0,0 +1,3 @@
+[Range-cloneContents.html]
+  bug: https://github.com/servo/servo/issues/36561
+  expected: ERROR

tests/wpt/meta/dom/ranges/Range-deleteContents.html.ini

@@ -0,0 +1,3 @@
+[Range-deleteContents.html]
+  bug: https://github.com/servo/servo/issues/36561
+  expected: ERROR

tests/wpt/meta/dom/ranges/Range-extractContents.html.ini

@@ -0,0 +1,3 @@
+[Range-extractContents.html]
+  bug: https://github.com/servo/servo/issues/36561
+  expected: ERROR

tests/wpt/meta/dom/ranges/Range-insertNode.html.ini

@@ -0,0 +1,3 @@
+[Range-insertNode.html]
+  bug: https://github.com/servo/servo/issues/36561
+  expected: ERROR

tests/wpt/meta/dom/ranges/Range-surroundContents.html.ini

@@ -0,0 +1,3 @@
+[Range-surroundContents.html]
+  bug: https://github.com/servo/servo/issues/36561
+  expected: ERROR