Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DashboardLayout and Account] A Few Issues #4332

Closed
aress31 opened this issue Oct 29, 2024 · 2 comments
Closed

[DashboardLayout and Account] A Few Issues #4332

aress31 opened this issue Oct 29, 2024 · 2 comments
Assignees
Labels
core Infrastructure work going on behind the scenes status: waiting for author Issue with insufficient information

Comments

@aress31
Copy link

aress31 commented Oct 29, 2024

Steps to reproduce

<DashboardLayout
  defaultSidebarCollapsed
  slots={{ toolbarAccount: () => <></>, sidebarFooter: SidebarFooter }}
>
const SidebarFooter = ({ mini }) => (
  <Account
    slotProps={{ preview: { variant: mini ? "condensed" : "expanded" } }}
  />
);

image

Current behavior

Is there a more effective way to disable the toolbarAccount? From my tests, the only method to disable it is as shown in the POC. It might be beneficial to introduce a hideAccount prop for the DashboardLayout. Additionally, when the Account is set as a sidebarFooter, the arrow connecting the Avatar to the menu is pointing in the wrong direction, see the POC.

Expected behavior

No response

Context

No response

Your environment

  System:
    OS: Windows 10 10.0.19045
  Binaries:
    Node: 20.5.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.5 - C:\Program Files\nodejs\npm.CMD
    pnpm: Not Found
  Browsers:
    Chrome: Not Found
    Edge: Chromium (129.0.2792.65)
  npmPackages:
    @emotion/react: ^11.13.3 => 11.13.3 
    @emotion/styled: ^11.13.0 => 11.13.0 
    @mui/base:  5.0.0-beta.60 
    @mui/core-downloads-tracker:  6.1.5 
    @mui/icons-material: ^6.1.5 => 6.1.5 
    @mui/lab: ^6.0.0-beta.13 => 6.0.0-beta.13 
    @mui/material: ^6.1.5 => 6.1.5 
    @mui/private-theming:  6.1.5 
    @mui/styled-engine:  6.1.5 
    @mui/system:  6.1.5 
    @mui/types:  7.2.18 
    @mui/utils:  6.1.5 
    @mui/x-charts: ^7.22.0 => 7.22.0 
    @mui/x-charts-vendor:  7.20.0 
    @mui/x-data-grid: ^7.22.0 => 7.22.0 
    @mui/x-date-pickers: ^7.22.0 => 7.22.0 
    @mui/x-internals:  7.21.0 
    @toolpad/core: ^0.8.1 => 0.8.1 
    @toolpad/utils:  0.8.1 
    @types/react:  18.3.3 
    react: ^18.3.1 => 18.3.1 
    react-dom: ^18.3.1 => 18.3.1 
    typescript:  4.9.5 

Search keywords: account dashboardlayout

@aress31 aress31 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 29, 2024
@bharatkashyap bharatkashyap added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 29, 2024
@bharatkashyap
Copy link
Member

The sidebar footer variant is still in progress at #4255 - feel free to share any feedback on the PR itself.

We discussed the hideAccount prop once earlier and felt like the current way is sufficient for the time being and not worth introducing a new prop on DashboardLayout

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Nov 4, 2024
Copy link

github-actions bot commented Nov 6, 2024

Since the issue is missing key information and has been inactive for 7 days, it has been automatically closed. If you wish to see the issue reopened, please provide the missing information.

@github-actions github-actions bot closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

3 participants