Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Feedback on Naming Convention | breadCrumbs #4128

Closed
douglaszaltron opened this issue Sep 20, 2024 · 2 comments · Fixed by #4143
Closed

[docs] Feedback on Naming Convention | breadCrumbs #4128

douglaszaltron opened this issue Sep 20, 2024 · 2 comments · Fixed by #4143
Labels
component: PageContainer enhancement This is not a bug, nor a new feature support: docs-feedback Feedback from documentation page

Comments

@douglaszaltron
Copy link

douglaszaltron commented Sep 20, 2024

Related page

https://mui.com/toolpad/core/react-page-container/#title-and-breadcrumbs

Kind of issue

Unclear explanations

Issue description

I found the use of PascalCase for the name "Breadcrumbs" to be odd. The props are named "breadCrumbs," which I think doesn’t look good. It would be better to use "breadcrumbs" since it's a single word and isn’t meant to be read separately.

Context

Docs

Search keywords: breadcrumbs

@douglaszaltron douglaszaltron added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Sep 20, 2024
@Janpot
Copy link
Member

Janpot commented Sep 23, 2024

You are right, Material UI also uses "breadcrumbs". Will update.

@Janpot Janpot added enhancement This is not a bug, nor a new feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 23, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @douglaszaltron! How was your experience with our support team?
We'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: PageContainer enhancement This is not a bug, nor a new feature support: docs-feedback Feedback from documentation page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants