Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultPropsProvider doesn't work with @mui/x packages #335

Open
trungutt opened this issue Nov 29, 2024 · 0 comments
Open

DefaultPropsProvider doesn't work with @mui/x packages #335

trungutt opened this issue Nov 29, 2024 · 0 comments
Assignees
Labels
customization: theme Centered around the theming features status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@trungutt
Copy link

trungutt commented Nov 29, 2024

Steps to reproduce

Following the migration guide to PigmentCSS, we use DefaultPropsProvider to migrate all our defaultProps customizations.

These customizations don't appear to work with PigmentCSS. Note that customizations from normal MUI components (Stack/Box/Typography...) continue to work.

One simplest example is to have this is to customize the DatePicker's opening icon

Screenshot 2024-11-29 at 10 10 21

and under PigmentCSS build, it always shows the default opening icon and not the custom one.

Note

We use a simple function to iterate through all MUI components and extract out all defaultProps to put in DefaultPropsProvider.

Current behavior

This recording shows the difference between our current runtime CSS vs experimental build with PigmentCSS

Screen.Recording.2024-11-29.at.10.14.22.mov

Expected behavior

MUI X packages should work with DefaultPropsProvider like any other normal MUI components.

Context

We are trying to move to PigmentCSS build

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: @mui/x, DefaultPropsProvider

@trungutt trungutt added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 29, 2024
@zannager zannager added the customization: theme Centered around the theming features label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: theme Centered around the theming features status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants