[DataGrid] Fix ugly prop-types for the pageStyle prop of the GridPrintExportMenuItem component
#15015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tExportMenuItem component
flaviendelangle
added
the
component: data grid
flaviendelangle
commented
Oct 18, 2024
| @@ -107,22 +107,7 @@ GridPrintExportMenuItem.propTypes = { | |||
| hideFooter: PropTypes.bool, | |||
| hideToolbar: PropTypes.bool, | |||
| includeCheckboxes: PropTypes.bool, | |||
| pageStyle: PropTypes.oneOfType([ | |||
| PropTypes.shape({ | |||
| '__@hasInstance@646': PropTypes.func.isRequired, | |||
There was a problem hiding this comment.
The 646 was changing value in other PRs 😬
See https://app.circleci.com/pipelines/github/mui/mui-x/69297/workflows/502b2d78-7789-4537-bd74-5085ef18653b/jobs/394896
|
Deploy preview: https://deploy-preview-15015--material-ui-x.netlify.app/ |
cherniavskii
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #14937