Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] AdapterLuxon.getMeridiemText does not work with es-US locale #9977

Closed
2 tasks done
andrew-laidlaw opened this issue Aug 9, 2023 · 1 comment · Fixed by #9979
Closed
2 tasks done

[pickers] AdapterLuxon.getMeridiemText does not work with es-US locale #9977

andrew-laidlaw opened this issue Aug 9, 2023 · 1 comment · Fixed by #9979
Assignees
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module!

Comments

@andrew-laidlaw
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Using Luxon 3.3.0

Steps:

  1. Use a DateTimePicker with AdapterLuxon
  2. Set the adapterLocale to "es-US" (Spanish language, 12h Clock)
  3. Click on the "calendar" button to display the date & time picker

import * as React from "react";
import { LocalizationProvider } from "@mui/x-date-pickers/LocalizationProvider"
import { AdapterLuxon } from "@mui/x-date-pickers/AdapterLuxon"
import { DateTimePicker } from "@mui/x-date-pickers/DateTimePicker"

export default function App() {
return (






);
}

Current behavior 😯

The MeridiemText is not displayed (only the labels, you can click on the same and select am / pm)

Screenshot 2023-08-09 095030

Expected behavior 🤔

The meridiem labels should be displayed

Context 🔦

Using the date time picker to let the use to select a date on a menu
The users can have different culture codes. en-US and es-US users both have 12hour clock

Your environment 🌎

npx @mui/envinfo

System:
OS: Windows 10 10.0.22000
Binaries:
Node: 18.13.0 - C:\Program Files\nodejs\node.EXE
Yarn: Not Found
npm: 8.19.3 - C:\Program Files\nodejs\npm.CMD
Browsers:
Chrome: Not Found
Edge: Spartan (44.22000.120.0), Chromium (115.0.1901.200)
npmPackages:
@mui/base: 5.0.0-beta.8
@mui/core-downloads-tracker: 5.14.1
@mui/lab: ^5.0.0-alpha.137 => 5.0.0-alpha.137
@mui/material: ^5.14.1 => 5.14.1
@mui/private-theming: 5.13.7
@mui/styled-engine: 5.13.2
@mui/styled-engine-sc: ^5.12.0 => 5.12.0
@mui/system: 5.14.1
@mui/types: 7.2.4
@mui/utils: 5.14.1
@mui/x-date-pickers: ^6.10.1 => 6.10.1
@types/react: 18.0.27
react: ^18.2.0 => 18.2.0
react-dom: ^18.2.0 => 18.2.0
styled-components: ^5.3.1 => 5.3.6
typescript: 4.9.5

Browser Chrome 115.0.5790.171 (Official Build) (64-bit) (Windows)
Luxon npm 3.3.0

Order ID or Support key 💳 (optional)

No response

@andrew-laidlaw andrew-laidlaw added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 9, 2023
@zannager zannager added the component: pickers This is the name of the generic UI component, not the React module! label Aug 9, 2023
@flaviendelangle flaviendelangle self-assigned this Aug 9, 2023
@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 9, 2023
@flaviendelangle
Copy link
Member

Thanks for your report!

@flaviendelangle flaviendelangle changed the title AdapterLuxon getMeridiemText in Spanish [pickers] AdapterLuxon.getMeridiemText does not work with es-US locale Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants