Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tree view] All selectable items should have aria-selected set to false when they are not selected #14982

Closed
joserodolfofreitas opened this issue Oct 15, 2024 · 6 comments · Fixed by #14991
Assignees
Labels
accessibility a11y bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!

Comments

@joserodolfofreitas
Copy link
Member

joserodolfofreitas commented Oct 15, 2024

Summary

All selectable items must have aria-selected=“false” by default (then aria-selected=“true” when selected). For the moment, we only have the aria-selected=“true” when it's selected, but without the aria-selected=“false”.

Accessibility issue reported by Ivalua.

Search keywords:

@joserodolfofreitas joserodolfofreitas added bug 🐛 Something doesn't work accessibility a11y component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Oct 15, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@flaviendelangle flaviendelangle self-assigned this Oct 16, 2024
@oliviertassinari oliviertassinari changed the title [tree view] All selectable items should have aria-selected set to false when they are not selected. [tree view] All selectable items should have aria-selected set to false when they are not selected Oct 16, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 16, 2024

Reference for why this report from Ivalua seems valid (it's frequent to receive invalid a11y reports from the community)

All nodes that are selectable but not selected have either aria-selected or aria-checked set to false.

https://www.w3.org/WAI/ARIA/apg/patterns/treeview/

@abdermaiza
Copy link

@joserodolfofreitas is this issue is closed because not considered as an issue, or already fixed?...

@joserodolfofreitas
Copy link
Member Author

@abdermaiza, it's closed as completed.
The implementation is at: #14991

@abdermaiza
Copy link

Can we test it somehow?

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 16, 2024

Can we test it somehow?

@abdermaiza You can the preview link that are on the PR descriptions: #14991.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants