Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] onColumnOrderChange not triggered in Firefox because event.dataTransfer is null #14263

Closed
DaryaHaprova opened this issue Aug 19, 2024 · 4 comments · Fixed by #14516
Assignees
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation feature: Reordering Related to the data grid Reordering feature

Comments

@DaryaHaprova
Copy link

DaryaHaprova commented Aug 19, 2024

Steps to reproduce

Link to live example: https://stackblitz.com/edit/react-zvxe1b?file=Demo.js
Steps:

  1. Try to reorder columns by drag and drop
  2. check console
  3. 'order change' - not logged
  4. error - event.dataTransfer is null
    Screenshot (347)
    Screenshot (348)

Current behavior

onColumnOrderChange not triggered

Expected behavior

onColumnOrderChange triggered

Context

I want to save columns order in local storage on change

Your environment

npx @mui/envinfo
  I used Firefox - 129.0.1
 
  System:
    OS: Windows 10 10.0.19045
  Binaries:
    Node: 18.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 9.5.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Chromium (127.0.2651.98)

Search keywords: dataTransfer, Firefox, onColumnOrderChange

@DaryaHaprova DaryaHaprova added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 19, 2024
@github-actions github-actions bot added the component: data grid This is the name of the generic UI component, not the React module! label Aug 19, 2024
@michelengelen michelengelen changed the title onColumnOrderChange not triggered in Firefox because event.dataTransfer is null [data grid] onColumnOrderChange not triggered in Firefox because event.dataTransfer is null Aug 19, 2024
@michelengelen michelengelen added the feature: Reordering Related to the data grid Reordering feature label Aug 19, 2024
@michelengelen
Copy link
Member

It seems like a but that got introduced in FF v129 ... it works in v128.
I am currently looking over the changelogs and bugzilla to find the cause for the change, but no luck so far.

@michelengelen
Copy link
Member

I just tested it in v130 and nightly ... so it only appears in v129 ...
Since v130 will release next month should we add a callout in the docs to inform users about this @mui/xgrid ?

@michelengelen michelengelen self-assigned this Aug 19, 2024
@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 20, 2024
@RajeshReddyM
Copy link

I experienced the same problem with version 129.0.1, but after updating Firefox this morning, it works fine with version 129.0.2.

@michelengelen michelengelen added the docs Improvements or additions to the documentation label Sep 2, 2024
michelengelen added a commit to michelengelen/mui-x that referenced this issue Sep 6, 2024
Copy link

github-actions bot commented Oct 2, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @DaryaHaprova! How was your experience with our support team?
We'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation feature: Reordering Related to the data grid Reordering feature
Projects
Status: 🆕 Needs refinement
Development

Successfully merging a pull request may close this issue.

3 participants