Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Time spend rendering Emotion/Pigment CSS #12401

Open
oliviertassinari opened this issue Mar 10, 2024 · 2 comments
Open

[data grid] Time spend rendering Emotion/Pigment CSS #12401

oliviertassinari opened this issue Mar 10, 2024 · 2 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! performance

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 10, 2024

Summary

This is a continuation of #11866 (comment) point 2. A significant amount of time is spent rendering React components, more specifically in the styled layer. We should be able to do better.

SCR-20240226-cywd

The potential savings might be about 14% (100ms out of the 700ms).

Examples

Shouldn't this be memo?

@oliviertassinari oliviertassinari added performance component: data grid This is the name of the generic UI component, not the React module! status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 10, 2024
@romgrk
Copy link
Contributor

romgrk commented Mar 10, 2024

I've been putting off working on the performance of the styles because I was hoping to solve this cleanly with the style API improvements and PigmentCSS. Doing that would take some amount of time though, we should probably estimate & prioritize the issue in that case.

We could also just hack around the problem by cramming more styles into GridRootStyles.

That component should probably by memo (as every component should), but I haven't seen it show up in any profile yet so I haven't paid attention to it. Usually the rows/cells take up so much of the time that it doesn't make sense to pay much attention to anything else for the moment.

@oliviertassinari
Copy link
Member Author

@romgrk delaying work on this makes sense to me 👍 , I opened the issue to have a placeholder for this.

@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! performance
Projects
None yet
Development

No branches or pull requests

3 participants