Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Add a recipe for correct extension of GridColumnUnsortedIcon #11973

Open
Tracked by #9328
michelengelen opened this issue Feb 7, 2024 · 0 comments
Open
Tracked by #9328
Labels
component: data grid This is the name of the generic UI component, not the React module! recipe

Comments

@michelengelen
Copy link
Member

michelengelen commented Feb 7, 2024

I think exporting it this way is not gonna work because:

  1. This component GridColumnUnsortedIcon is a slot and differently exists for material and joy design systems.
  2. Since this file isn't exported like export * from './GridColumnUnsortedIcon', this added export will make no difference anyways.

Possible Options:

  1. We document it somehow and users keep defining on their side. (Like @michelengelen did on csb)
  2. We export it from the specific design entry point, so the users will import it like
    a. import { GridColumnUnsortedIconProps } from '@mui/x-data-grid/material';
    b. import { GridColumnUnsortedIconProps } from '@mui/x-data-grid/joy';
  3. Export them from the root with different names, like GridColumnUnsortedIconPropsMaterial, GridColumnUnsortedIconPropsJoy.

To me 1 and 2 feel better, 3 I would not consider since this will negate the initial idea of isolating the exports for different design systems.
For 2 though, I'm not sure if it'll be discoverable enough for the users, since it will not be obvious from what path they need to import this as we have all other exports from the root path.

Looping @cherniavskii since the problem is a bit broader, should apply to all other design system related exports. Would be nice to hear how you'd approach this. Or if you already thought around this during Joy UI support.

CC @michelengelen

Originally posted by @MBilalShafi in #11472 (comment)

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 7, 2024
@michelengelen michelengelen added component: data grid This is the name of the generic UI component, not the React module! recipe and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! recipe
Projects
Status: 🆕 Needs refinement
Development

No branches or pull requests

1 participant