-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Support changing start of week day on AdapterLuxon
#10805
Comments
We could provide the method as unstable |
Hey guys! Do we have any sense of when would this be fixed? I'd be open to work on the change if necessary too 🚀 |
Hi, Do you need any of the features released since this problem has been introduced ? |
No, right now we've been using a version that allows the workaround, so we can wait a bit for this implementation. But we will be upgrading it as soon as it released 🚀 |
The clean fix will be merged in the v7 alpha branch. Bu you can apply the exact same behavior [like on this codesandbox](https://codesandbox.io/s/date- If you encounter any issue, please let me know so that I can fix our implementation. |
Created from: #10790 (comment)
There is also the concern of whether we are willing to risk breaking something we don't know.
Luxon currently doesn't support such a feature natively, because the
Intl
API doesn't have the full support ofgetWeekInfo
: moment/luxon#954Considering our position as "consumers" of the given library, we could simply refrain from coming up with custom implementations until a native one is provided by
luxon
. 🤔Relevant issue and a proposed custom adapter: #7670 (comment) that we basically broke with: #10345.
Search keywords:
The text was updated successfully, but these errors were encountered: