Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] Export empty theme.json if Design Kit is in default state #428

Open
robinpalicka opened this issue Dec 6, 2024 · 2 comments
Open
Labels
figma scope: sync Issues related to the Material UI Sync Figma plugin

Comments

@robinpalicka
Copy link

robinpalicka commented Dec 6, 2024

Summary

Material UI Sync plugin generates 3333 lines long theme.json file even if you generate it from default MUI Kit. As a developer, you are loosing ability to see what's overridden on first glance, if this generated theme.json file is used.

Ideally, plugin should generate empty theme.json, when Design Kit is in default and untouched state. Only if some variables or e.g. Button master component is changed, then it should generate overrides for modified definitions.

Examples

Plugin version: v0.1 BETA
Design Kit version: MUI for Figma v6.1.0 - Material UI
Generated file from untouched Design Kit: theme.json

Search keywords: default theme

@robinpalicka robinpalicka added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 6, 2024
@zannager zannager added figma scope: sync Issues related to the Material UI Sync Figma plugin labels Dec 6, 2024
@SaavanFreed
Copy link

SaavanFreed commented Dec 12, 2024

Agreed. Why is the Sync Plugin not just generating a diff from the default theme object..?

@oliviertassinari oliviertassinari changed the title Export empty theme.json if Design Kit is in default state. Export empty theme.json if Design Kit is in default state Dec 22, 2024
@oliviertassinari oliviertassinari changed the title Export empty theme.json if Design Kit is in default state [sync] Export empty theme.json if Design Kit is in default state Dec 22, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 22, 2024

We have a default set of values that we need to update each time we do a new release of the figma kit: https://github.com/mui/mui-private/tree/master/packages/material-ui-sync-figma/src/defaults. We didn't, hence the plugin is unusable right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
figma scope: sync Issues related to the Material UI Sync Figma plugin
Projects
None yet
Development

No branches or pull requests

5 participants