Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You have a new comment on Material UI for Figma (and MUI X) by Paul Whelan #394

Closed
mui-bot2 opened this issue Sep 2, 2024 · 1 comment
Closed
Assignees
Labels

Comments

@mui-bot2
Copy link

mui-bot2 commented Sep 2, 2024

Figma

You have a new comment on Material UI for Figma (and MUI X)
Paul Whelan
@olivtassinari Thanks for your comment. I understand the principles and what you’re trying to do, but I don’t think the way it’s been implemented in MUI is quite right. Currently, all the <paper-elevations> are listed under <background> in the variables, but wouldn’t it make more sense to have them under <elevation> instead? It would be more effective to have tones (e.g., grey-10, etc.) housed under <background> so I can control the colors specifically for my backgrounds. This isn’t possible unless I go into the Material Colors variables and amend those, but that only works if those colors align with your brand. Of course, I could change them, but I think it’s best to leave those alone.
Reply to comment

Search keywords:

@mui-bot2 mui-bot2 added figma status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 2, 2024
@adrianmanea
Copy link
Collaborator

Answered by Olivier!

@zannager zannager removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants