[material-ui][InputLabel] Changed size prop value from normal to medium
#45235
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perkrlsn
force-pushed
the
input-label-size
branch
from
15739d7 to
e92e0cf
Compare
perkrlsn
force-pushed
the
input-label-size
branch
from
e92e0cf to
222959d
Compare
ZeeshanTamboli
changed the title
normal to mediumnormal to medium
ZeeshanTamboli
changed the title
normal to mediumnormal to medium
ZeeshanTamboli
added
package: material-ui
1 task
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
|
@DiegoAndai @aarongarciah Should we include this breaking change in v7? A similar PR was opened before (#36188). It’s just a prop value change for consistency. I've also added it to the v7 upgrade guide: https://deploy-preview-45235--material-ui.netlify.app/material-ui/migration/upgrade-to-v7/ What do you think? Worth including? |
|
@ZeeshanTamboli +1 for being consistent. |
Comment on lines
+70
to
+79
| The `size` prop for `InputLabel` now follows the standard naming convention used across Material UI. `'normal'` has been replaced with `'medium'` for consistency. | ||
|
|
||
| If you were using `size="normal"`, update it to `size="medium"`: | ||
|
|
||
| ```diff | ||
| -<InputLabel size="normal">Label</InputLabel> | ||
| +<InputLabel size="medium">Label</InputLabel> | ||
| ``` | ||
|
|
||
| This aligns `InputLabel` with other components like `Button` and `TextField`, which use `'small' | 'medium'`. The default behavior remains unchanged, so no updates are needed unless you explicitly set `size="normal"`. |
There was a problem hiding this comment.
Suggested change
| The `size` prop for `InputLabel` now follows the standard naming convention used across Material UI. `'normal'` has been replaced with `'medium'` for consistency. | |
| If you were using `size="normal"`, update it to `size="medium"`: | |
| ```diff | |
| -<InputLabel size="normal">Label</InputLabel> | |
| +<InputLabel size="medium">Label</InputLabel> | |
| ``` | |
| This aligns `InputLabel` with other components like `Button` and `TextField`, which use `'small' | 'medium'`. The default behavior remains unchanged, so no updates are needed unless you explicitly set `size="normal"`. | |
| The `size` prop for `InputLabel` now follows the standard naming convention used across other components like `Button` and `TextField`. `'normal'` has been replaced with `'medium'` for consistency. | |
| If you were using `size="normal"`, update it to `size="medium"`: | |
| ```diff | |
| -<InputLabel size="normal">Label</InputLabel> | |
| +<InputLabel size="medium">Label</InputLabel> |
The default behavior remains unchanged, so no updates are needed unless you explicitly set size="normal".
|
@ZeeshanTamboli we should add a codemod, too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell the
InputLabelis the only component with a'small' | 'normal'size prop. Looking through the rest of components (albeit with a very rudimentary search) the standard seems to be'small' | 'medium'.This PR updates the propery for the
InputLabelto match other components.