Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] renderInput is using an old api #44145

Open
svidskiy opened this issue Oct 17, 2024 · 1 comment
Open

[Autocomplete] renderInput is using an old api #44145

svidskiy opened this issue Oct 17, 2024 · 1 comment
Assignees
Labels
component: autocomplete This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature

Comments

@svidskiy
Copy link

svidskiy commented Oct 17, 2024

Steps to reproduce

The props passed through renderInput use the old API InputProps and InputLabelProps.

image
image

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

System: OS: Windows 11 10.0.22621 Binaries: Node: 20.17.0 - C:\Program Files\nodejs\node.EXE npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD pnpm: 9.9.0 - C:\Program Files\nodejs\pnpm.CMD Browsers: Chrome: Not Found Edge: Chromium (127.0.2651.74) npmPackages: @emotion/react: ^11.11.4 => 11.13.3 @emotion/styled: ^11.11.5 => 11.13.0 @mui/icons-material: ^6.1.3 => 6.1.3 @mui/lab: 6.0.0-beta.11 => 6.0.0-beta.11 @mui/material: ^6.1.3 => 6.1.3 @mui/material-nextjs: ^6.1.3 => 6.1.3 @mui/styled-engine-sc: ^6.1.3 => 6.1.3 @mui/system: ^6.1.3 => 6.1.3 @mui/utils: ^6.1.3 => 6.1.3 @mui/x-data-grid-pro: ^7.20.0 => 7.20.0 @mui/x-date-pickers: ^7.20.0 => 7.20.0 @mui/x-date-pickers-pro: ^7.20.0 => 7.20.0 @mui/x-license: ^7.20.0 => 7.20.0 @types/react: ^18.2.66 => 18.3.5 react: ^18.2.0 => 18.3.1 react-dom: ^18.2.0 => 18.3.1 typescript: ^5.2.2 => 5.5.4

Search keywords: autocomplete, api

@svidskiy svidskiy added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 17, 2024
@svidskiy svidskiy changed the title Autocomplete: renderInput is using an old api [Autocomplete] renderInput is using an old api Oct 17, 2024
@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Oct 17, 2024
@mnajdova
Copy link
Member

It makes sense to be consistent and move the InputProps, inputProps and InputLabelProps into a slotProps key in the options object, but this would be a breaking change. As a first step we could provide both APIs and deprecate the current ones, with the thought of removing them in a future major release.

@mnajdova mnajdova added enhancement This is not a bug, nor a new feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Development

No branches or pull requests

4 participants