Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Update examples to use CSS variables #43787

Closed
siriwatknp opened this issue Sep 17, 2024 · 3 comments · Fixed by #43856
Closed

[examples] Update examples to use CSS variables #43787

siriwatknp opened this issue Sep 17, 2024 · 3 comments · Fixed by #43856
Labels
examples Relating to /examples v6.x

Comments

@siriwatknp
Copy link
Member

siriwatknp commented Sep 17, 2024

The CSS variables API is stable, it should be adopted in all the examples. Also, I notice some of the theming API (like using ownerState still exist) need to be cleanup.

Search keywords: examples, css variables

@siriwatknp siriwatknp added examples Relating to /examples v6.x labels Sep 17, 2024
@wilhelmlofsten
Copy link
Contributor

Hello Siriwat!

My name is Wilhelm, and I’m excited to start contributing to the MUI project!

So im new to Open source contribution, but have experience with React.js and Javascript development, and im eager to contribute to MUI!

Im trying to find a "good first issue" but have difficulty finding one, so wondering if this open issue is a good place to start?
Regarding the issue, is this then for all the examples of usage with CSS variable and updating all the examples with this API?

Copy link

github-actions bot commented Oct 8, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@oliviertassinari
Copy link
Member

Great, one step closer to make CSS variables the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples v6.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants