Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][theme] Wrong cssVariables type in Theme interface #43607

Closed
tomasnikl opened this issue Sep 4, 2024 · 2 comments
Closed

[material-ui][theme] Wrong cssVariables type in Theme interface #43607

tomasnikl opened this issue Sep 4, 2024 · 2 comments
Assignees
Labels
customization: theme Centered around the theming features package: material-ui Specific to @mui/material status: waiting for author Issue with insufficient information typescript

Comments

@tomasnikl
Copy link

tomasnikl commented Sep 4, 2024

Steps to reproduce

Link to live example

Current behavior

wrong Theme interface. cssVariables should be boolean, not false.

export interface Theme extends BaseTheme, CssVarsProperties {
  cssVariables?: false;
  components?: Components<BaseTheme>;
  unstable_sx: (props: SxProps<Theme>) => CSSObject;
  unstable_sxConfig: SxConfig;
}

Expected behavior

export interface Theme extends BaseTheme, CssVarsProperties {
  cssVariables?: boolean;
  components?: Components<BaseTheme>;
  unstable_sx: (props: SxProps<Theme>) => CSSObject;
  unstable_sxConfig: SxConfig;
}

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: theme, cssVariables, createTheme, css, variables

@tomasnikl tomasnikl added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 4, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [Theme] - wrong Theme interace [material-ui] Wrong cssVariables type in Theme interace Sep 4, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui] Wrong cssVariables type in Theme interace [material-ui] Wrong cssVariables type in Theme interface Sep 4, 2024
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work typescript package: material-ui Specific to @mui/material customization: theme Centered around the theming features and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 4, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui] Wrong cssVariables type in Theme interface [material-ui][theme] Wrong cssVariables type in Theme interface Sep 4, 2024
@siriwatknp
Copy link
Member

@tomasnikl Thanks for the feedback. What issue have you experienced?

@siriwatknp siriwatknp added status: waiting for author Issue with insufficient information and removed bug 🐛 Something doesn't work labels Sep 5, 2024
Copy link

Since the issue is missing key information and has been inactive for 7 days, it has been automatically closed. If you wish to see the issue reopened, please provide the missing information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: theme Centered around the theming features package: material-ui Specific to @mui/material status: waiting for author Issue with insufficient information typescript
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants