Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest tag for published package #43538

Closed
MonstraG opened this issue Aug 28, 2024 · 7 comments
Closed

Update latest tag for published package #43538

MonstraG opened this issue Aug 28, 2024 · 7 comments
Assignees
Labels
component: slider This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base

Comments

@MonstraG
Copy link
Contributor

MonstraG commented Aug 28, 2024

Steps to reproduce

This is not really a bug, but it broke my builds, and I have a repro:

  1. add mui packages to package.json with version latest or just copy the version from npm
  2. start using them and try building the app

Current behavior

Build fails because 5.0.0-beta.40 is marked as latest but is incompatible with other latest packages (v5 or v6 of mui/material)

error in the build:

build: ../../node_modules/.pnpm/@[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/@mui/base/useSlider/useSlider.js
 Attempted import error: 'unstable_useIsFocusVisible' is not exported from '@mui/utils' (imported as 'useIsFocusVisible').

Expected behavior

It builds

Context

I believe the last version is 5.0.0-beta.58 now.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: latest mui/base v5

@MonstraG MonstraG added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 28, 2024
@zannager zannager added the package: base-ui Specific to @mui/base label Aug 28, 2024
@oliviertassinari oliviertassinari transferred this issue from mui/base-ui Aug 30, 2024
@siriwatknp
Copy link
Member

@oliviertassinari Why do you transfer this issue to the core repo?

@siriwatknp
Copy link
Member

@MonstraG Do you have @mui/base explicitly installed in your package.json?

@siriwatknp siriwatknp added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 11, 2024
@oliviertassinari oliviertassinari removed the status: waiting for author Issue with insufficient information label Sep 11, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 11, 2024

Why do you transfer this issue to the core repo?

@siriwatknp Because the issue is with useSlider.ts. When I search where the source of it is: https://github.com/search?q=org%3Amui+useSlider.ts&type=code? I find it's in this repository. So I assume it's this repository scope?


Regarding the issue, the error says that the problem is with @mui/[email protected] installed, so the first thing to check is the package.json: https://unpkg.com/browse/@mui/[email protected]/package.json. There, the problem seems clear:

  "@mui/utils": "^6.0.0-alpha.5"
},

range scope with an alpha? yeah, no, this is never going to work. The error says useIsFocusVisible is missing, yeap, sure, it got removed in #42467, released under "@mui/utils": "^6.0.0-beta.0", so 🙃.

Build fails because 5.0.0-beta.40 is marked as latest but is incompatible with other latest packages (v5 or v6 of mui/material)

This is not accurate 5.0.0-beta.40 is compatible. 5.0.0-beta.43 isn't.

SCR-20240912-chrj

5.0.0-beta-58 seems to work fine https://www.npmjs.com/package/@mui/base?activeTab=versions.

To close this issue, I think that it's simply about doing one thing:

  • update our latest npm tag to match with next. Since we release as "latest" again with the release of Material UI v6 stable, it should be fine.

@oliviertassinari oliviertassinari added the component: slider This is the name of the generic UI component, not the React module! label Sep 11, 2024
@MonstraG
Copy link
Contributor Author

@MonstraG Do you have @mui/base explicitly installed in your package.json?

Yes, to import stuff (mostly tabs) from it.

@siriwatknp
Copy link
Member

@oliviertassinari thanks for the info, updated 5.0.0-beta.58 to latest. @MonstraG please check and feel free to close the issue.

@MonstraG
Copy link
Contributor Author

In all the ways I can observe, 5.0.0-beta.58 is latest and it works. Closing, thanks!

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @MonstraG! How was your experience with our support team?
We'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
None yet
Development

No branches or pull requests

5 participants