Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Support full screen / screen-size switcher for demos #43331

Open
bharatkashyap opened this issue Jul 8, 2024 · 2 comments
Open
Labels
scope: docs-infra Specific to the docs-infra product

Comments

@bharatkashyap
Copy link
Member

bharatkashyap commented Jul 8, 2024

Context

Benchmarks

Screenshot 2024-07-08 at 7 11 07 AM SCR-20240817-qvjd

Solution

Search keywords:

Search keywords:

@bharatkashyap bharatkashyap added the scope: docs-infra Specific to the docs-infra product label Jul 8, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 4, 2024

This would need to be combined with "iframe": true to work.

Up to now, my method to test mobile was to either open the dev tools, it gets me down to 800px width, and then enable the mobile emulator on the docs. I have some doubts about the importance of this pain. It might be a high opportunity cost to others.

@bharatkashyap
Copy link
Member Author

I have some doubts about the importance of this pain. It might be a high opportunity cost to others.

I think the pain is larger in the context of layout components, when being able to demonstrate how the component behaves both on large screen sizes and mobile can be an important selling point. We could emulate the behaviour of the switcher on https://mui-blocks.netlify.app/content

@oliviertassinari oliviertassinari transferred this issue from mui/toolpad Aug 17, 2024
@oliviertassinari oliviertassinari changed the title [docs] Support screen-size switcher for Core components demos [docs-infra] Support screen-size switcher for Core components demos Aug 17, 2024
@oliviertassinari oliviertassinari changed the title [docs-infra] Support screen-size switcher for Core components demos [docs-infra] Support full screen / screen-size switcher for demos Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

No branches or pull requests

2 participants