Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add Pigment CSS integration guide #42781

Closed
wants to merge 7 commits into from
Closed

[docs] Add Pigment CSS integration guide #42781

wants to merge 7 commits into from

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 28, 2024 •
edited by alelthomas
Loading

@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Jun 28, 2024
@mui-bot
Copy link

mui-bot commented Jun 28, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 95b419d

@o-alexandrov
Copy link

@siriwatknp sorry for disturbing, is it expected at the moment that extendTheme from @mui/material passed to a vite PigmentCSS plugin (based on the guide here) doesn't change any styles of the components, when using latest @mui/material & PigmentCSS?

  • if it's not expected, then I'd create a separate issue

@siriwatknp
Copy link
Member Author

@siriwatknp sorry for disturbing, is it expected at the moment that extendTheme from @mui/material passed to a vite PigmentCSS plugin (based on the guide here) doesn't change any styles of the components, when using latest @mui/material & PigmentCSS?

  • if it's not expected, then I'd create a separate issue

It should change, please create a separate issue. FYI, this is a wip docs please don't take it as final.

@o-alexandrov o-alexandrov mentioned this pull request Jul 8, 2024
Closed
o-alexandrov
o-alexandrov reviewed Jul 1, 2024
View reviewed changes
docs/data/material/migration/migrating-to-v6/migrating-to-pigment-css.md
- <Box component="img" src="..." sx={{ width: 24, height: 24 }}>
- ...
- </Box>
+ <div style={{ display: 'flex' }}>
Copy link

@o-alexandrov o-alexandrov Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean here to use style with the div & img below; or should it be sx?

  • based on the TypeScript type extension of the global for HTML attributes, I believe you meant to specify sx here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps, that's a mistake.

@siriwatknp
Copy link
Member Author

Moved to #42819

@siriwatknp siriwatknp closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova left review comments

@o-alexandrov o-alexandrov o-alexandrov left review comments

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs][pigment-css] Add opt-in migration to Pigment CSS
4 participants
@siriwatknp @mui-bot @o-alexandrov @mnajdova