-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[slider] Vertical slider incorrectly exposed as horizontal in the accessibility tree in Chrome<124 #635
Comments
As of 2023 Chromium plans to deprecate The recommendation is to use For older browsers that we need to support, there are still (non-standard) properties to fall back to: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_writing_modes/Vertical_controls#creating_vertical_range_sliders_in_older_browsers |
@mj12albert oh, I didn't know interesting. I guess it's mdn/content#32142. |
We discussed this and decided to:
|
This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. |
Great first step. I'm reopening per:
There is nothing about Material Design in fixing this in Material UI, so I believe we want the two things to be done in coordination, by the same component owner. |
Steps to reproduce
Steps:
or open https://mui.com/material-ui/react-slider/#vertical-sliders
Current behavior
Expected behavior
Context
https://issues.chromium.org/issues/40739626 was fixed 3 years ago after Sebastian reported it, so we should now be able to remove the content in https://mui.com/material-ui/react-slider/#vertical-sliders and apply the style. This style is needed because aria-orientation is no correctly interpreted per https://issues.chromium.org/issues/40736841.
I noticed this in #636, it was weird.
Closing this issue also means getting https://mui.com/material-ui/react-slider/#vertical-sliders fixed. I opened this issue in Base UI to be at the root, for the Slider component owner.
Your environment
npx @mui/envinfo
Search keywords: -
The text was updated successfully, but these errors were encountered: