Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Conditionally load Tailwind CSS #617

Open
oliviertassinari opened this issue Sep 15, 2024 · 0 comments
Open

[docs-infra] Conditionally load Tailwind CSS #617

oliviertassinari opened this issue Sep 15, 2024 · 0 comments
Assignees
Labels
dx Related to developers' experience performance priority: important This change can make a difference scope: docs-infra Specific to the docs-infra product status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 15, 2024

Steps to reproduce

Link to live example: (required)

Steps:

  1. Open https://master--base-ui.netlify.app/components/react-dialog/
  2. Check the dev tools. Get a huge pile of Tailwind CSS variables spam in the devtools
Screen.Recording.2024-09-15.at.03.20.33.mov
  1. Spend time during critical page loading to load a CSS file that is unused:
SCR-20240915-dtxd

Same in https://mui.com/material-ui/react-dialog/.


It's the same behavior in https://mui.com/material-ui/react-dialog/. It has been driving me crazy for the last 18+ months 😄

Current behavior

Load Tailwind CSS even when not needed.

Expected behavior

Only load Tailwind CSS file when needed on the page.

Context

It's not that important for Base UI, but since it's docs-infra, I think that it's important for Material UI to get clarify about the style as a developer, and as a maintainer, to feel the DX of what you are building like a developer will.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: -

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer performance scope: docs-infra Specific to the docs-infra product dx Related to developers' experience labels Sep 15, 2024
@oliviertassinari oliviertassinari added the priority: important This change can make a difference label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Related to developers' experience performance priority: important This change can make a difference scope: docs-infra Specific to the docs-infra product status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants