Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine data-has-nested-dialogs attribute name #1169

Open
vladmoroz opened this issue Dec 18, 2024 · 0 comments
Open

Refine data-has-nested-dialogs attribute name #1169

vladmoroz opened this issue Dec 18, 2024 · 0 comments
Labels
component: alert dialog This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module!

Comments

@vladmoroz
Copy link
Contributor

I think we've rushed with the attribute name a bit, probably should be data-nested-dialog-open similarly to data-popup-open, data-panel-open. "Has nested dialogs" doesn't imply the nested dialog is open.
@vladmoroz vladmoroz added component: alert dialog This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module! labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: alert dialog This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vladmoroz